-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial Indicator and other unused Dependencies removed #285
Tutorial Indicator and other unused Dependencies removed #285
Conversation
@opticod Let's wait for this PR. I tried your way - |
@opticod However, for others , only compile files('libs/zipsigner-lib-1.17.jar') is unused which also I am removing. |
compile files('libs/zipsigner-lib-1.17.jar') | ||
compile files('libs/zipsigner-lib-optional-1.16.jar') | ||
compile files('libs/pkix-1.51.0.0.jar') | ||
compile files('libs/kellinwood-logging-android-1.4.jar') | ||
compile files('libs/kellinwood-logging-lib-1.1.jar') | ||
compile files('libs/kellinwood-logging-log4j-1.0.jar') | ||
compile files('libs/axml.jar') | ||
compile 'com.viewpagerindicator:library:2.4.1@aar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingblazer Can compile 'com.viewpagerindicator:library:2.4.1@aar'
be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opticod Yes, I have implemented my own indicator. Forgot to remove it. Done now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingblazer, u also forgot to remove them from source-code/app/libs
. Also remove compile fileTree(include: ['*.jar'], dir: 'libs')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opticod Done!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉 @codingblazer
Seems like we removed necessary libraries. APK creation is failing. Will fix this. |
Added via 5cbae12 |
#262 (Part 3)
I have removed the Tutorial Indicator Dependency and other dependencies.