Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Indicator and other unused Dependencies removed #285

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Tutorial Indicator and other unused Dependencies removed #285

merged 1 commit into from
Dec 13, 2016

Conversation

codingblazer
Copy link
Contributor

#262 (Part 3)
I have removed the Tutorial Indicator Dependency and other dependencies.

@codingblazer
Copy link
Contributor Author

@opticod Let's wait for this PR. I tried your way -
Remove first compile fileTree(include: ['*.jar'], dir: 'libs') then try to remove each. but again app was running fine when axml.jar was removed.
I think, I have to look at Gradle lint tool to find unused dependencies. I will soon commit changes.

@codingblazer
Copy link
Contributor Author

codingblazer commented Dec 13, 2016

@opticod
compile files('libs/core-1.51.0.0.jar')
compile files('libs/prov-1.51.0.0.jar')
There not used anywhere in project. I am removing these.
However, library is used for security purpose (crytography). Any idea why it was included ?

However, for others , only compile files('libs/zipsigner-lib-1.17.jar') is unused which also I am removing.
I have removed codacy issues also.

compile files('libs/zipsigner-lib-1.17.jar')
compile files('libs/zipsigner-lib-optional-1.16.jar')
compile files('libs/pkix-1.51.0.0.jar')
compile files('libs/kellinwood-logging-android-1.4.jar')
compile files('libs/kellinwood-logging-lib-1.1.jar')
compile files('libs/kellinwood-logging-log4j-1.0.jar')
compile files('libs/axml.jar')
compile 'com.viewpagerindicator:library:2.4.1@aar'
Copy link
Collaborator

@opticod opticod Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingblazer Can compile 'com.viewpagerindicator:library:2.4.1@aar' be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opticod Yes, I have implemented my own indicator. Forgot to remove it. Done now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingblazer, u also forgot to remove them from source-code/app/libs. Also remove compile fileTree(include: ['*.jar'], dir: 'libs')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opticod Done!!

Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉 @codingblazer

@opticod opticod merged commit 930dabb into BuildmLearn:bug-fixes Dec 13, 2016
@opticod
Copy link
Collaborator

opticod commented Dec 13, 2016

Seems like we removed necessary libraries. APK creation is failing. Will fix this.

@opticod
Copy link
Collaborator

opticod commented Dec 13, 2016

Added via 5cbae12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants