-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawables Size Optimized #283
Drawables Size Optimized #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked few of them. Ensure all of them are fine.
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" android:width="24dp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really big in simulator.
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shade is different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes doing it
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shade is again not perfect. Looks like more brighter.
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again shade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opticod No, its same as previous one. I have checked.
@opticod I have checked each and these need modification - library, group, assignment, input. I am changing it, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shade is little more brighter, but need to be slight darker.. for now revert back the mentioned drawables to png. After that I can merge it
@@ -0,0 +1,5 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert back for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opticod Are you asking these 5 - record,capslock,input,group, assignment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingblazer , Mistake, revert back for 3
- Assignment (all dpi)
- Input (all dpi)
- Record_voice(all dpi)
And can you add vector for ic_keyboard_capslock_black_down_24dp.png
as u have did for ic_keyboard_capslock_black_24dp.png
?
@codingblazer, Lets fix this, and freeze a version for testing. |
@opticod I am doing this only right now. Will take max 5-10 min. |
@opticod Done. Also added the Caps_down you asked for. |
#262 (Part-2)
All non sharp drawables has been reduced in size using tinypng and sharp drawables has been replaced by vector drawables wherever possible.
Raw file Size Decreased by 2 MB (from 3.7 MB to 1.7 MB) for Drawables in Apk Size Distribution.