Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backpress should deselect selected items if any. #255

Closed
m-murad opened this issue Dec 7, 2016 · 5 comments
Closed

Backpress should deselect selected items if any. #255

m-murad opened this issue Dec 7, 2016 · 5 comments
Assignees
@m-murad
Labels
Dec-2016 Release

Comments

@m-murad
Copy link
Contributor

m-murad commented Dec 7, 2016

Currently - In "Saved Projects", "Saved APKs" and "My Drafts" if the user has selected items and presses back button the user is taken to the last open fragment.

Intended - User presses back button, if there are any items selected they should be deselected. After that if the user presses back key last fragment (preferably "Home" fragment) should open
@m-murad
Copy link
Contributor Author

m-murad commented Dec 7, 2016

@opticod @croozeus
Should I make a PR to solve this?

@m-murad m-murad changed the title Backpress should deselect items if any. Backpress should deselect selected items if any. Dec 8, 2016
@opticod
Copy link
Collaborator

opticod commented Dec 10, 2016

@free4murad, Fix this before Dec Release

@opticod
Copy link
Collaborator

opticod commented Dec 12, 2016

@free4murad, Are you working on this?

@m-murad
Copy link
Contributor Author

m-murad commented Dec 12, 2016

@opticod
Yes, I will make a PR soon.

This was referenced Dec 12, 2016
Closed
Closed
opticod added a commit that referenced this issue Dec 13, 2016
@opticod
FIXED #255, Backpress should deselect any selected item if any
f4d1567
opticod added a commit that referenced this issue Dec 13, 2016
@opticod
Merge pull request #295 from BuildmLearn/backpress-fix
7e3f924 
FIXED #255, Backpress should deselect any selected item if any
@opticod
Copy link
Collaborator

opticod commented Dec 13, 2016

Closed via #295

@opticod opticod closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-murad m-murad

Labels
Dec-2016 Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@opticod @m-murad