Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

Fix issue with port is undefined in hybrid SPA sample #282

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

salman90
Copy link
Contributor

@salman90 salman90 commented Apr 11, 2023

Purpose

  • The port variable is not declared in the authController.js, which is causing the app to crash.

Does this introduce a breaking change?

[ x ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@derisen derisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to address-feel free to merge afterwards

@salman90 salman90 merged commit da557b4 into main Apr 14, 2023
@derisen derisen deleted the fix-issue-with-port branch June 25, 2023 03:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The variable port is undefined. The execution fails if process.env.port is defined.
2 participants