Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

Refactoring CAE code in the sample #262

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Refactoring CAE code in the sample #262

merged 4 commits into from
Mar 9, 2023

Conversation

salman90
Copy link
Contributor

@salman90 salman90 commented Mar 3, 2023

Purpose

  • Refactoring CAE logic to separate the Authentication logic from the React components.

Does this introduce a breaking change?

[ x ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x  ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@salman90 salman90 requested a review from derisen March 3, 2023 22:13
@salman90 salman90 linked an issue Mar 3, 2023 that may be closed by this pull request
Copy link
Contributor

@derisen derisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salman90 looks good! Can we do the same for CAE code in 6-1 sample?

@salman90 salman90 merged commit c021cf0 into main Mar 9, 2023
@derisen derisen deleted the refactor-component branch June 25, 2023 03:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor component to handle claims challenge
2 participants