[WIP] Add DoubleResurrection strategy #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drvinceknight
requested changes
Apr 4, 2017
|
|
||
| def test_strategy(self): | ||
| # Starts by Cooperating | ||
| self.first_play_test(C) |
There was a problem hiding this comment.
Would you be able to re write these tests using the new framework?
I know you started writing this before the change but we'd appreciate it :)
marcharper
requested changes
Apr 9, 2017
| name = "DoubleResurrection" | ||
| player = axelrod.DoubleResurrection | ||
| expected_classifier = { | ||
| 'memory_depth': 1, |
| # Starts by Cooperating | ||
| self.first_play_test(C) | ||
|
|
||
| actions = [(C, C), (C, D), (D, C), (C, D), (D, C)] |
There was a problem hiding this comment.
Can we make sure we have tests that check both 5 round depth behaviors? I think the tests will need to be at least 6 rounds of history to make sure they are triggered.
|
@souravsingh I've pushed those extra tests and fixed the memory length 👍 |
drvinceknight
approved these changes
Apr 16, 2017
|
What happened here? Looks like we need a rebase? |
Done. |
marcharper
approved these changes
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds DoubleResurrection strategy to Axelrod.
I have added a WIP tag to check if the tests pass properly.