-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fragment/streamline the Moran process beginning documentation #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
reviewed
Apr 3, 2017
Due to the high computational cost of a single Moran process, an approximate | ||
Moran process is implemented that can make use of cached outcomes of games. The | ||
following code snippet will generate a Moran process in which a `Defector` | ||
cooperates (gets a high score) against another `Defector`. First the cache is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what "... a Defector
cooperates (gets a high score) against another Defector
" means. How can a Defector cooperate?
Yup, poorly worded. Will fix.
…On Mon, 3 Apr 2017, 11:38 Owen Campbell, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/tutorials/further_topics/approximate_moran_processes.rst
<#962 (comment)>
:
> @@ -0,0 +1,26 @@
+.. _approximate-moran-process:
+
+Approximate Moran Process
+=========================
+
+Due to the high computational cost of a single Moran process, an approximate
+Moran process is implemented that can make use of cached outcomes of games. The
+following code snippet will generate a Moran process in which a `Defector`
+cooperates (gets a high score) against another `Defector`. First the cache is
I don't understand what "... a Defector cooperates (gets a high score)
against another Defector" means. How can a Defector cooperate?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#962 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACCGWm4OTEf3J0RnT2Ly_BTlvuWjjP_wks5rsMwggaJpZM4MxUvX>
.
|
I've changed it a bit. Let me know if you think it can still be clearer 👍 |
meatballs
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #961
I've also grabbed the commit from #960.