-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to averagecopier #847
Add type hints to averagecopier #847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could you add axelrod/strategies/averagecopier.py
to type_tests.sh
please.
The tests are just warnings so not actually triggering failures.
@drvinceknight What exactly is the conflict here? |
You seem to have a slightly older version of Let us know if any of that is unclear. |
@drvinceknight I've messed this branch.And you seem to have made a new commit just now. Is there any way to backtrack to before? |
Would it be easier to delete the local branch and pull from the branch at my fork again? |
Yup, that's probably the easiest thing to do in this case. If adding the module to |
…to typeHint-averagecopier
ac8d035
to
44b0385
Compare
@drvinceknight Fortunately it worked. :) |
Great! |
#808
mypy produces no errors. Same issue with the tests as #846 .