-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping support for Python 2 #818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro argument Python 3 format.
marcharper
approved these changes
Jan 15, 2017
@rkty13 Can you also update the issue with what is left to do? Even if it's just the last few lines above. Thanks! |
Done! |
drvinceknight
approved these changes
Jan 16, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a great contribution! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #801. I have gone through all of the files and removed any support for Python 2 that I could find.
Overview of the changes I made:
float()
cast or had one of the operands as a float (e.g.1.0/...
or1./...
.u''
super()
.__future__
module.Some things I could not change:
random_choice()
andrandrange()
in https://github.com/Axelrod-Python/Axelrod/blob/master/axelrod/random_.py as noted in #801.Overall I think I have caught most of the differences between Python 2 and Python 3. Please let me know if I have missed anything or if I need to add anything else to this PR.