-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom matches #1397
Merged
Merged
Add custom matches #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vince Knight <vince@vknight.org>
Co-authored-by: Nikoleta Glynatsi <glynatsi@evolbio.mpg.de>
The current seed was not giving the result written in the comment.
The way the results are calculated in a tournament is not consistent with the calculations being done in the match. This would involve a bit more work.
f8b6807
to
2512ec2
Compare
I do not know why the rtds sphinx docs build is failing. Here's the end of the traceback:
|
marcharper
approved these changes
Oct 26, 2021
If it's a generator it needs to be in a list context before the first element can be accessed. Maybe bumping some versions up will help? |
I'll try a few things 👍 |
I have also set the configuration on rtds to no longer point at this empty file.
…d into add-custom-matches
Someone found the fix, it's related to sphinx-doc/sphinx@13803a7 I have pinned docutils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #1394.
In practice it adds very little to the source code: just makes it possible to pass a match class to the Moran Process.
I originally wanted to do the same with the tournament however the way we calculate results for the tournament is a bit more complex and with
5.0.0
in mind might need a bit more discussion.So this PR is mainly documentation with a tutorial to show how to reproduce the Krapohl, S., Ocelík, V. & Walentek, D.M. The instability of globalization: applying evolutionary game theory to global trade cooperation. Public Choice 188, 31–51 (2021). https://doi.org/10.1007/s11127-020-00799-1
paper