-
Notifications
You must be signed in to change notification settings - Fork 85
getting started, step 5 - changed order of instructions for clarity #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/getting-started/installation.md
Outdated
1. Extract both downloads to your desktop | ||
|
||
1. If you have chosen [**Manual Driver Installation**](#driver-updates), run `Disable Drivers Installation in Windows Update.reg` from the extracted Atlas Playbook download and restart | ||
**If you have chosen [**Manual Driver Installation**](#driver-updates)**, run `Disable Drivers Installation in Windows Update.reg` from the extracted Atlas Playbook download and restart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still says to run the .reg file from the extracted download, before the actual download step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb, I'm going to change this soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where you're coming from with the potential unclarity. I do believe though that the better solution for clarity might be to indent the "If you have chosen Manual Drive Installation …"-step under step 3 (Extract both downloads …).
Or you could make it a title-less admonition @m33o44
This renders as a box with a coloured border. |
That's what I wanted to do first I'm going to change that later today, I've got other things to do rn |
changed the "manual driver installation"-part into a note-box after step 6. (extract the files to your desktop)
the box of "manual driver installation" has been changed - title has been removed - color was changed from "note" to "info"
Now that I'm reading through the new instructions order again, I'm wondering if it even makes sense. |
Uh, yeah that's how it's supposed to work. |
then the change of order wouldn't even universally work for the manual driver installation |
Type
Questions
Yes
Yes
Describe your pull request
I changed the order of instructions in step 5 of getting-started
1 - 3 were moved after 7 so that the instructions for updating Windows come first
the number in step 4. is removed. The “if” part of the sentence is highlighted and moved to the first position, separate from the other steps
This should make it clearer that Windows should be updated before installing AtlasOS, and the manual driver installation step is separated from the other steps to avoid confusion