feat: support element access of enum #2950
Open
+1,135
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK but I'll have to review later |
|
ping @CountBleck |
CountBleck
approved these changes
Oct 14, 2025
Comment on lines
+1543
to
+1545
| for (let _keys = Map_keys(members), _values = Map_values(members), i = 1, k = _keys.length; i <= k; ++i) { | ||
| let enumValueName = unchecked(_keys[k - i]); | ||
| let member = unchecked(_values[k - i]); |
There was a problem hiding this comment.
Suggested change
| for (let _keys = Map_keys(members), _values = Map_values(members), i = 1, k = _keys.length; i <= k; ++i) { | |
| let enumValueName = unchecked(_keys[k - i]); | |
| let member = unchecked(_values[k - i]); | |
| for (let _keys = Map_keys(members), _values = Map_values(members), i = _keys.length - 1; i >= 0; --i) { | |
| let enumValueName = unchecked(_keys[i]); | |
| let member = unchecked(_values[i]); |
Doesn't this work?
| return true; | ||
| } | ||
|
|
||
| private ensureEnumToString(enumElement: Enum, reportNode: Node): string | null { |
There was a problem hiding this comment.
Could you add a couple blank lines in here? It's a little hard to read
| let resolver = this.resolver; | ||
| let targetElement = resolver.lookupExpression(targetExpression, this.currentFlow, Type.auto, ReportMode.Swallow); | ||
| if (targetElement && targetElement.kind == ElementKind.Enum) { | ||
| const elementExpr = this.compileExpression(expression.elementExpression, Type.i32, Constraints.ConvImplicit); |
There was a problem hiding this comment.
It looks like we're allowing Enum[Enum.X] but not Enum["X"] (only Enum.X, the property access expression, is allowed). This is likely a good thing to have, unless users really want to get enum members with computed string values (which should probably be discouraged regardless).
(It also seems like we don't have a good error for someObject["property"] and we use TS2329 instead, so a good error for Enum["X"] isn't necessary for now.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.