Skip to content

Use before(:each) rather than before(:all) #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Use before(:each) rather than before(:all) #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4648fda
Use `before(:each)` rather than `before(:all)` as recommended [here](…
jgfoster Feb 16, 2021
a012fd4
Update CHANGELOG.md.
jgfoster Oct 3, 2021
fa2aca9
Merge branch 'master' into report_compile_errors
Oct 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `--min-free-space=N` command-line argument to fail if free space is below requred value

### Changed
- Properly report compile errors in GitHub Actions (#296)
- Put build artifacts in a separate directory to reduce clutter.
- Change 266 files from CRLF to LF.
- Update .gitattributes so we have consistent line endings
Expand Down
2 changes: 1 addition & 1 deletion spec/testsomething_unittests_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
context "file #{tfn} (using #{compiler})" do
around(:example) { |example| fld.in_pristine_fake_libraries_dir(example) }

before(:all) do
before(:each) do
@cpp_library = backend.install_local_library(cpp_lib_path)
@exe = @cpp_library.build_for_test_with_configuration(path, [], compiler, config.gcc_config("uno"))
end
Expand Down