AlgorithmAndLeetCode · pull · Apr 3, 2024 · Apr 2, 2024 · Apr 2, 2024 · Apr 2, 2024
diff --git a/compression/huffman.py b/compression/huffman.py
@@ -40,7 +40,7 @@ def build_tree(letters: list[Letter]) -> Letter | TreeNode:
     Run through the list of Letters and build the min heap
     for the Huffman Tree.
     """
-    response: list[Letter | TreeNode] = letters  # type: ignore
+    response: list[Letter | TreeNode] = list(letters)
     while len(response) > 1:
         left = response.pop(0)
         right = response.pop(0)
@@ -59,7 +59,7 @@ def traverse_tree(root: Letter | TreeNode, bitstring: str) -> list[Letter]:
     if isinstance(root, Letter):
         root.bitstring[root.letter] = bitstring
         return [root]
-    treenode: TreeNode = root  # type: ignore
+    treenode: TreeNode = root
     letters = []
     letters += traverse_tree(treenode.left, bitstring + "0")
     letters += traverse_tree(treenode.right, bitstring + "1")

diff --git a/data_structures/arrays/__init__.py b/data_structures/arrays/__init__.py
diff --git a/data_structures/binary_tree/binary_search_tree.py b/data_structures/binary_tree/binary_search_tree.py
@@ -294,9 +294,9 @@ def remove(self, value: int) -> None:
             predecessor = self.get_max(
                 node.left
             )  # Gets the max value of the left branch
-            self.remove(predecessor.value)  # type: ignore
+            self.remove(predecessor.value)  # type: ignore[union-attr]
             node.value = (
-                predecessor.value  # type: ignore
+                predecessor.value  # type: ignore[union-attr]
             )  # Assigns the value to the node to delete and keep tree structure
 
     def preorder_traverse(self, node: Node | None) -> Iterable:
@@ -336,7 +336,7 @@ def inorder(curr_node: Node | None) -> list[Node]:
     """
     node_list = []
     if curr_node is not None:
-        node_list = inorder(curr_node.left) + [curr_node] + inorder(curr_node.right)
+        node_list = [*inorder(curr_node.left), curr_node, *inorder(curr_node.right)]
     return node_list
 
 

diff --git a/data_structures/hashing/tests/__init__.py b/data_structures/hashing/tests/__init__.py
diff --git a/data_structures/linked_list/rotate_to_the_right.py b/data_structures/linked_list/rotate_to_the_right.py
@@ -63,7 +63,7 @@ def insert_node(head: Node | None, data: int) -> Node:
     while temp_node.next_node:
         temp_node = temp_node.next_node
 
-    temp_node.next_node = new_node  # type: ignore
+    temp_node.next_node = new_node
     return head
 
 

diff --git a/digital_image_processing/morphological_operations/__init__.py b/digital_image_processing/morphological_operations/__init__.py
diff --git a/dynamic_programming/subset_generation.py b/dynamic_programming/subset_generation.py
@@ -45,7 +45,7 @@ def subset_combinations(elements: list[int], n: int) -> list:
     for i in range(1, r + 1):
         for j in range(i, 0, -1):
             for prev_combination in dp[j - 1]:
-                dp[j].append(tuple(prev_combination) + (elements[i - 1],))
+                dp[j].append((*prev_combination, elements[i - 1]))
 
     try:
         return sorted(dp[n])

diff --git a/electronics/__init__.py b/electronics/__init__.py
diff --git a/electronics/circular_convolution.py b/electronics/circular_convolution.py
@@ -37,8 +37,7 @@ def circular_convolution(self) -> list[float]:
         using matrix method
 
         Usage:
-        >>> import circular_convolution as cc
-        >>> convolution = cc.CircularConvolution()
+        >>> convolution = CircularConvolution()
         >>> convolution.circular_convolution()
         [10, 10, 6, 14]
 

diff --git a/fractals/__init__.py b/fractals/__init__.py
diff --git a/fractals/mandelbrot.py b/fractals/mandelbrot.py
@@ -17,7 +17,7 @@
 
 import colorsys
 
-from PIL import Image  # type: ignore
+from PIL import Image
 
 
 def get_distance(x: float, y: float, max_step: int) -> float:

diff --git a/geometry/__init__.py b/geometry/__init__.py
diff --git a/graphics/bezier_curve.py b/graphics/bezier_curve.py
@@ -2,7 +2,7 @@
 # https://www.tutorialspoint.com/computer_graphics/computer_graphics_curves.htm
 from __future__ import annotations
 
-from scipy.special import comb  # type: ignore
+from scipy.special import comb
 
 
 class BezierCurve:

diff --git a/greedy_methods/__init__.py b/greedy_methods/__init__.py
diff --git a/linear_algebra/src/gaussian_elimination_pivoting/__init__.py b/linear_algebra/src/gaussian_elimination_pivoting/__init__.py
diff --git a/linear_programming/__init__.py b/linear_programming/__init__.py
diff --git a/maths/entropy.py b/maths/entropy.py
@@ -96,8 +96,8 @@ def analyze_text(text: str) -> tuple[dict, dict]:
     The first dictionary stores the frequency of single character strings.
     The second dictionary stores the frequency of two character strings.
     """
-    single_char_strings = Counter()  # type: ignore
-    two_char_strings = Counter()  # type: ignore
+    single_char_strings = Counter()  # type: ignore[var-annotated]
+    two_char_strings = Counter()  # type: ignore[var-annotated]
     single_char_strings[text[-1]] += 1
 
     # first case when we have space at start.

diff --git a/maths/numerical_analysis/__init__.py b/maths/numerical_analysis/__init__.py
diff --git a/maths/odd_sieve.py b/maths/odd_sieve.py
@@ -33,7 +33,7 @@ def odd_sieve(num: int) -> list[int]:
                 0, ceil((num - i_squared) / (i << 1))
             )
 
-    return [2] + list(compress(range(3, num, 2), sieve))
+    return [2, *list(compress(range(3, num, 2), sieve))]
 
 
 if __name__ == "__main__":

diff --git a/maths/special_numbers/__init__.py b/maths/special_numbers/__init__.py
diff --git a/matrix/spiral_print.py b/matrix/spiral_print.py
@@ -116,7 +116,9 @@ def spiral_traversal(matrix: list[list]) -> list[int]:
     [1, 2, 3, 4, 8, 12, 11, 10, 9, 5, 6, 7] + spiral_traversal([])
     """
     if matrix:
-        return list(matrix.pop(0)) + spiral_traversal(list(zip(*matrix))[::-1])  # type: ignore
+        return list(matrix.pop(0)) + spiral_traversal(
+            [list(row) for row in zip(*matrix)][::-1]
+        )
     else:
         return []
 

diff --git a/matrix/tests/test_matrix_operation.py b/matrix/tests/test_matrix_operation.py
@@ -12,7 +12,7 @@
 import sys
 
 import numpy as np
-import pytest  # type: ignore
+import pytest
 
 # Custom/local libraries
 from matrix import matrix_operation as matop

diff --git a/neural_network/activation_functions/__init__.py b/neural_network/activation_functions/__init__.py
diff --git a/neural_network/activation_functions/mish.py b/neural_network/activation_functions/mish.py
@@ -7,7 +7,8 @@
 """
 
 import numpy as np
-from softplus import softplus
+
+from .softplus import softplus
 
 
 def mish(vector: np.ndarray) -> np.ndarray:

diff --git a/project_euler/problem_092/sol1.py b/project_euler/problem_092/sol1.py
@@ -68,7 +68,7 @@ def chain(number: int) -> bool:
     """
 
     if CHAINS[number - 1] is not None:
-        return CHAINS[number - 1]  # type: ignore
+        return CHAINS[number - 1]  # type: ignore[return-value]
 
     number_chain = chain(next_number(number))
     CHAINS[number - 1] = number_chain

diff --git a/project_euler/problem_104/sol1.py b/project_euler/problem_104/sol1.py
@@ -15,7 +15,7 @@
 
 import sys
 
-sys.set_int_max_str_digits(0)  # type: ignore
+sys.set_int_max_str_digits(0)
 
 
 def check(number: int) -> bool:

diff --git a/pyproject.toml b/pyproject.toml
@@ -6,16 +6,16 @@ lint.ignore = [    # `ruff rule S101` for a description of that rule
   "EM101",    # Exception must not use a string literal, assign to variable first
   "EXE001",   # Shebang is present but file is not executable" -- FIX ME
   "G004",     # Logging statement uses f-string
-  "INP001",   # File `x/y/z.py` is part of an implicit namespace package. Add an `__init__.py`. -- FIX ME
-  "PGH003",   # Use specific rule codes when ignoring type issues -- FIX ME
   "PLC1901",  # `{}` can be simplified to `{}` as an empty string is falsey
   "PLW060",   # Using global for `{name}` but no assignment is done -- DO NOT FIX
   "PLW2901",  # PLW2901: Redefined loop variable -- FIX ME
   "PT011",    # `pytest.raises(Exception)` is too broad, set the `match` parameter or use a more specific exception
   "PT018",    # Assertion should be broken down into multiple parts
-  "RUF00",    # Ambiguous unicode character and other rules
+  "RUF001",   # String contains ambiguous {}. Did you mean {}?
+  "RUF002",   # Docstring contains ambiguous {}. Did you mean {}?
+  "RUF003",   # Comment contains ambiguous {}. Did you mean {}?
+  "RUF007",   # Prefer itertools.pairwise() over zip() when iterating over successive pairs
   "S101",     # Use of `assert` detected -- DO NOT FIX
-  "S105",     # Possible hardcoded password: 'password'
   "S113",     # Probable use of requests call without timeout -- FIX ME
   "S311",     # Standard pseudo-random generators are not suitable for cryptographic purposes -- FIX ME
   "SLF001",   # Private member accessed: `_Iterator` -- FIX ME

diff --git a/scripts/validate_filenames.py b/scripts/validate_filenames.py
@@ -4,7 +4,7 @@
 try:
     from .build_directory_md import good_file_paths
 except ImportError:
-    from build_directory_md import good_file_paths  # type: ignore
+    from build_directory_md import good_file_paths  # type: ignore[no-redef]
 
 filepaths = list(good_file_paths())
 assert filepaths, "good_file_paths() failed!"

diff --git a/scripts/validate_solutions.py b/scripts/validate_solutions.py
@@ -21,8 +21,8 @@
 def convert_path_to_module(file_path: pathlib.Path) -> ModuleType:
     """Converts a file path to a Python module"""
     spec = importlib.util.spec_from_file_location(file_path.name, str(file_path))
-    module = importlib.util.module_from_spec(spec)  # type: ignore
-    spec.loader.exec_module(module)  # type: ignore
+    module = importlib.util.module_from_spec(spec)  # type: ignore[arg-type]
+    spec.loader.exec_module(module)  # type: ignore[union-attr]
     return module
 
 
@@ -92,7 +92,7 @@ def test_project_euler(solution_path: pathlib.Path) -> None:
     problem_number: str = solution_path.parent.name[8:].zfill(3)
     expected: str = PROBLEM_ANSWERS[problem_number]
     solution_module = convert_path_to_module(solution_path)
-    answer = str(solution_module.solution())  # type: ignore
+    answer = str(solution_module.solution())
     answer = hashlib.sha256(answer.encode()).hexdigest()
     assert (
         answer == expected

diff --git a/web_programming/covid_stats_via_xpath.py b/web_programming/covid_stats_via_xpath.py
@@ -7,7 +7,7 @@
 from typing import NamedTuple
 
 import requests
-from lxml import html  # type: ignore
+from lxml import html
 
 
 class CovidData(NamedTuple):

diff --git a/web_programming/recaptcha_verification.py b/web_programming/recaptcha_verification.py
@@ -43,7 +43,7 @@
 
 def login_using_recaptcha(request):
     # Enter your recaptcha secret key here
-    secret_key = "secretKey"
+    secret_key = "secretKey"  # noqa: S105
     url = "https://www.google.com/recaptcha/api/siteverify"
 
     # when method is not POST, direct user to login page