Llama 3.1 RoPE scaling #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is imported from the original Llama reference implementation: https://github.com/meta-llama/llama-models/blob/7890266c5a3ccd29e739d53a71ea968bcf4ca400/models/llama3/reference_impl/model.py#L45 Note that the function does not have any effect on the original model code as long as the use_scaled parameter is false (the default).
These are aligned with HF ones, so it will be easier to implement rope scaling as it is done in Llama3.1.
|
CC @qihqi for info |
2 tasks
|
Hi, you probably also need to add an entry in here: https://github.com/AI-Hypercomputer/jetstream-pytorch/blob/main/jetstream_pt/third_party/llama/model_exportable.py#L294 |
qihqi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RoPE scaling support for Llama. This will enable the Llama 3.1, 3.2 and 3.3 (not vision) to be supported.