Skip to content

Commit adcbb68

Browse files
bobzhangbobzhang
committed
continue
1 parent 2a58d7a commit adcbb68

File tree

7 files changed

+0
-62
lines changed

7 files changed

+0
-62
lines changed

Diff for: ‎jscomp/core/j.ml

-6
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,6 @@ and expression_desc =
124124
like [+true], note this ast talks using js
125125
terminnology unless explicity stated
126126
*)
127-
| Json_stringify of expression
128-
(* TODO: in the future, it might make sense to group primitivie by type,
129-
which makes optimizations easier
130-
{[ JSON.stringify(value, replacer[, space]) ]}
131-
*)
132-
133127

134128
(* TODO:
135129
add

Diff for: ‎jscomp/core/js_analyzer.ml

-2
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ let rec no_side_effect_expression_desc (x : J.expression_desc) =
117117
| Array_copy _
118118
| Js_not _
119119
| String_of_small_int_array _
120-
| Json_stringify _
121120
| Cond _
122121

123122
| FlatCall _
@@ -259,7 +258,6 @@ let rec eq_expression
259258
| Typeof _
260259
| Js_not _
261260
| String_of_small_int_array _
262-
| Json_stringify _
263261
| Cond _
264262
| FlatCall _
265263
| String_access _

Diff for: ‎jscomp/core/js_dump.ml

-9
Original file line numberDiff line numberDiff line change
@@ -518,14 +518,6 @@ and
518518
P.string f "()" ;
519519
cxt
520520
)
521-
| Json_stringify e
522-
->
523-
P.group f 1 (fun _ ->
524-
P.string f L.json ;
525-
P.string f L.dot;
526-
P.string f L.stringify;
527-
P.paren_group f 1 (fun _ -> expression 0 cxt f e )
528-
)
529521
| Char_to_int e ->
530522
begin match e.expression_desc with
531523
| String_access (a,b) ->
@@ -1087,7 +1079,6 @@ and statement_desc top cxt f (s : J.statement_desc) : Ext_pp_scope.t =
10871079
| String_append _
10881080
| Char_of_int _
10891081
| Char_to_int _
1090-
| Json_stringify _
10911082
| Math _
10921083
| Var _
10931084
| Str _

Diff for: ‎jscomp/core/js_exp_make.ml

-4
Original file line numberDiff line numberDiff line change
@@ -450,10 +450,6 @@ let char_to_int ?comment (v : t) : t =
450450
let array_copy ?comment e : t =
451451
{ comment ; expression_desc = Array_copy e}
452452

453-
454-
(* let to_json_string ?comment e : t =
455-
{ comment; expression_desc = Json_stringify e } *)
456-
457453
let rec string_append ?comment (e : t) (el : t) : t =
458454
match e.expression_desc , el.expression_desc with
459455
| Str(_,a), String_append ({expression_desc = Str(_,b)}, c) ->

Diff for: ‎jscomp/core/js_fold.ml

-5
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,6 @@ class virtual fold =
138138
like [+true], note this ast talks using js
139139
terminnology unless explicity stated
140140
*)
141-
(* TODO: in the future, it might make sense to group primitivie by type,
142-
which makes optimizations easier
143-
{[ JSON.stringify(value, replacer[, space]) ]}
144-
*)
145141
(* TODO:
146142
add
147143
{[ Assert of bool * expression ]}
@@ -344,7 +340,6 @@ class virtual fold =
344340
| Typeof _x -> let o = o#expression _x in o
345341
| Js_not _x -> let o = o#expression _x in o
346342
| String_of_small_int_array _x -> let o = o#expression _x in o
347-
| Json_stringify _x -> let o = o#expression _x in o
348343
| Seq (_x, _x_i1) ->
349344
let o = o#expression _x in let o = o#expression _x_i1 in o
350345
| Cond (_x, _x_i1, _x_i2) ->

Diff for: ‎jscomp/core/js_map.ml

-5
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,6 @@ class virtual map =
151151
like [+true], note this ast talks using js
152152
terminnology unless explicity stated
153153
*)
154-
(* TODO: in the future, it might make sense to group primitivie by type,
155-
which makes optimizations easier
156-
{[ JSON.stringify(value, replacer[, space]) ]}
157-
*)
158154
(* TODO:
159155
add
160156
{[ Assert of bool * expression ]}
@@ -372,7 +368,6 @@ class virtual map =
372368
| Js_not _x -> let _x = o#expression _x in Js_not _x
373369
| String_of_small_int_array _x ->
374370
let _x = o#expression _x in String_of_small_int_array _x
375-
| Json_stringify _x -> let _x = o#expression _x in Json_stringify _x
376371
| Seq (_x, _x_i1) ->
377372
let _x = o#expression _x in
378373
let _x_i1 = o#expression _x_i1 in Seq (_x, _x_i1)

Diff for: ‎lib/whole_compiler.ml

-31
Original file line numberDiff line numberDiff line change
@@ -63323,12 +63323,6 @@ and expression_desc =
6332363323
like [+true], note this ast talks using js
6332463324
terminnology unless explicity stated
6332563325
*)
63326-
| Json_stringify of expression
63327-
(* TODO: in the future, it might make sense to group primitivie by type,
63328-
which makes optimizations easier
63329-
{[ JSON.stringify(value, replacer[, space]) ]}
63330-
*)
63331-
6333263326

6333363327
(* TODO:
6333463328
add
@@ -69594,10 +69588,6 @@ class virtual fold =
6959469588
like [+true], note this ast talks using js
6959569589
terminnology unless explicity stated
6959669590
*)
69597-
(* TODO: in the future, it might make sense to group primitivie by type,
69598-
which makes optimizations easier
69599-
{[ JSON.stringify(value, replacer[, space]) ]}
69600-
*)
6960169591
(* TODO:
6960269592
add
6960369593
{[ Assert of bool * expression ]}
@@ -69800,7 +69790,6 @@ class virtual fold =
6980069790
| Typeof _x -> let o = o#expression _x in o
6980169791
| Js_not _x -> let o = o#expression _x in o
6980269792
| String_of_small_int_array _x -> let o = o#expression _x in o
69803-
| Json_stringify _x -> let o = o#expression _x in o
6980469793
| Seq (_x, _x_i1) ->
6980569794
let o = o#expression _x in let o = o#expression _x_i1 in o
6980669795
| Cond (_x, _x_i1, _x_i2) ->
@@ -70100,7 +70089,6 @@ let rec no_side_effect_expression_desc (x : J.expression_desc) =
7010070089
| Array_copy _
7010170090
| Js_not _
7010270091
| String_of_small_int_array _
70103-
| Json_stringify _
7010470092
| Cond _
7010570093

7010670094
| FlatCall _
@@ -70242,7 +70230,6 @@ let rec eq_expression
7024270230
| Typeof _
7024370231
| Js_not _
7024470232
| String_of_small_int_array _
70245-
| Json_stringify _
7024670233
| Cond _
7024770234
| FlatCall _
7024870235
| String_access _
@@ -71518,10 +71505,6 @@ let char_to_int ?comment (v : t) : t =
7151871505
let array_copy ?comment e : t =
7151971506
{ comment ; expression_desc = Array_copy e}
7152071507

71521-
71522-
(* let to_json_string ?comment e : t =
71523-
{ comment; expression_desc = Json_stringify e } *)
71524-
7152571508
let rec string_append ?comment (e : t) (el : t) : t =
7152671509
match e.expression_desc , el.expression_desc with
7152771510
| Str(_,a), String_append ({expression_desc = Str(_,b)}, c) ->
@@ -84628,14 +84611,6 @@ and
8462884611
P.string f "()" ;
8462984612
cxt
8463084613
)
84631-
| Json_stringify e
84632-
->
84633-
P.group f 1 (fun _ ->
84634-
P.string f L.json ;
84635-
P.string f L.dot;
84636-
P.string f L.stringify;
84637-
P.paren_group f 1 (fun _ -> expression 0 cxt f e )
84638-
)
8463984614
| Char_to_int e ->
8464084615
begin match e.expression_desc with
8464184616
| String_access (a,b) ->
@@ -85197,7 +85172,6 @@ and statement_desc top cxt f (s : J.statement_desc) : Ext_pp_scope.t =
8519785172
| String_append _
8519885173
| Char_of_int _
8519985174
| Char_to_int _
85200-
| Json_stringify _
8520185175
| Math _
8520285176
| Var _
8520385177
| Str _
@@ -88229,10 +88203,6 @@ class virtual map =
8822988203
like [+true], note this ast talks using js
8823088204
terminnology unless explicity stated
8823188205
*)
88232-
(* TODO: in the future, it might make sense to group primitivie by type,
88233-
which makes optimizations easier
88234-
{[ JSON.stringify(value, replacer[, space]) ]}
88235-
*)
8823688206
(* TODO:
8823788207
add
8823888208
{[ Assert of bool * expression ]}
@@ -88450,7 +88420,6 @@ class virtual map =
8845088420
| Js_not _x -> let _x = o#expression _x in Js_not _x
8845188421
| String_of_small_int_array _x ->
8845288422
let _x = o#expression _x in String_of_small_int_array _x
88453-
| Json_stringify _x -> let _x = o#expression _x in Json_stringify _x
8845488423
| Seq (_x, _x_i1) ->
8845588424
let _x = o#expression _x in
8845688425
let _x_i1 = o#expression _x_i1 in Seq (_x, _x_i1)

0 commit comments

Comments
 (0)