Merge branch 'master' into adapt-build-to-react-ppx-in-syntax

Author: jchavarri

.gitmodules

@@ -1,7 +1,12 @@
 [submodule "ocaml"]
 	path = ocaml
 	url = https://github.com/rescript-lang/ocaml
+	ignore = untracked
 [submodule "syntax"]
 	path = syntax
 	url = https://github.com/rescript-lang/syntax
 	branch = master
+[submodule "ninja"]
+	path = ninja
+	url = git@github.com:rescript-lang/ninja.git
+	ignore = untracked

.npmignore

@@ -38,4 +38,6 @@ package/
 .nyc_output/
 themes
 vendor/js_of_ocaml.bc
-syntax/
+syntax/
+*.log
+ninja

Changes.md

@@ -1,4 +1,74 @@
 `*` means  potential break changes
+
+# 8.3.1
+This is a minor bug fix release for 8.3.0
+- capture warnings when rebuild without enforce warn-as-error
+- #4716 internal, make ninja a submodule in dev process
+- #4722 better dataflow for cases like `let {a;b} as obj = ...`
+- no need call `caml_enter_blocking_section` for single threaded compiler
+- #4739 fix the interaction of exotic filenames like `[id]` with the build system.
+
+# 8.3
+
+- #4694, #4712 improving/customizing the underlying ninja build system, better performance  
+
+- #4681, #4710 creating persistent lib/bs.compiler.log per each build for editor diagnostics
+
+- #4688, #4707 better error message
+
+- * #4702  remove nativeint module which is not meaningful on js platform
+
+- #4701 support both `bs.val` and `val` attributes, in the future to recommend the shorter ones
+
+- #4693 Fix the compiler runtime issue, always flush err_formatter when at_exit
+
+- #4687, #4689, #4691 allow user to customize js file extension in bsconfig.json (checkout the schema )
+
+- #4685, #4624, #4690 allow more character set in filenames to make rescript play better with react native and next.js
+
+- #4684 fix the raise of Sys.is_directory, make bsb works better with Emacs temp files
+
+- #4679 better error message for nonrec GADT
+
+- #4671, #4678 better strategies to remove staled output for the build system
+
+- #4676 (internal) add Config.syntax_kind so that some changes in super_errors can be made upstream
+
+- #4650, #4656, #4657, #4662 always warn-as-error while not degrading user expereince (with the help of build system)
+
+- #4661 (internal) not depending on upstream compenv module
+
+- #4639, #4642 refined static analysis to generate better code 
+
+- #4636, #4641 es6 default import support 
+
+- #4638 clean up the confusing error message over uncurry label
+
+- #4637 remove unneeded mention of BuckleScript in uncurried message
+
+- #4623 better data flow inference for common pattern: `let {a,b,c} = ...`
+
+- #4622 add html element & observer phantom types
+
+- #4618 fix combination of bs.obj with bs.as so that bs.as can carry more kinds of playload
+
+- #4613 (internal) pass down @inlined attribute from upstream. (the info is passed down, how to make use of it is not done yet)
+
+- #4609 Lift the restriction that user can only define a type with less than 256 constructors
+
+
+- #4606, #3961 (internal) use is_a_functor from upstream instead of guessing
+
+- #4605 (experimental) take `@@inline` attribute into consideration for functions
+
+- #4604 enhance Random module
+
+- #4600, #4599 fix missing bounds checking for Bytes.set
+
+- #4597 fix Js.Array and Js.Array2 the wrong return type for `from` method
+
+- #4513 better error message when interface/implementation mismatches (done in commit db485f1)
+
 # 8.2
 
 - `bsc -fmt myFile` now changed to `bsc -format myFile`

darwin/ninja.exe

@@ -9,6 +9,15 @@
             ],
             "description": "es6-global generate relative `require` paths instead of relying on NodeJS' module resolution. Default: commonjs."
         },
+        "suffix-spec" : {
+            "enum" : [
+                ".js",
+                ".bs.js",
+                ".mjs",
+                ".cjs"
+            ],
+            "description": "suffix of generated js files, default to [.js] "
+        },
         "module-format-object": {
             "type": "object",
             "properties": {
@@ -18,6 +27,9 @@
                 "in-source": {
                     "type": "boolean",
                     "description": "Default: false."
+                },
+                "suffix" : {
+                    "$ref" : "#/definitions/suffix-spec"
                 }
             },
             "required": [
@@ -484,11 +496,7 @@
             "description": "(Not needed usually) arguments to pass to `refmt` above. Default: `[\"--print\", \"binary\"]`."
         },
         "suffix" : {
-            "enum" : [
-                ".js",
-                ".bs.js"
-            ],
-            "description": "suffix of generated js files, default to [.js] "
+            "$ref" : "#/definitions/suffix-spec"
         }
     },
     "additionalProperties": false,

docs/docson/build-schema.json

@@ -14,7 +14,6 @@
     "package.json",
     "COPYING.LESSER",
     "Changes.md",
-    "CONTRIBUTING_EXTRA.md",
     "CONTRIBUTING.md",
     "DCO.md",
     "README.md",
@@ -113,9 +112,7 @@
     "callback.js",
     "caml_array_extern.js",
     "caml_array.js",
-    "caml_bytes_extern.js",
     "caml_bytes.js",
-    "caml_char.js",
     "caml_exceptions.js",
     "caml_external_polyfill.js",
     "caml_float_extern.js",
@@ -160,7 +157,6 @@
     "dom.js",
     "filename.js",
     "format.js",
-    "gc.js",
     "genlex.js",
     "hashtbl.js",
     "int32.js",
@@ -202,7 +198,6 @@
     "map.js",
     "marshal.js",
     "moreLabels.js",
-    "nativeint.js",
     "node_buffer.js",
     "node_child_process.js",
     "node_fs.js",
@@ -220,7 +215,6 @@
     "scanf.js",
     "set.js",
     "sort.js",
-    "spacetime.js",
     "stack.js",
     "std_exit.js",
     "stdLabels.js",
@@ -283,9 +277,7 @@
     "callback.js",
     "caml_array_extern.js",
     "caml_array.js",
-    "caml_bytes_extern.js",
     "caml_bytes.js",
-    "caml_char.js",
     "caml_exceptions.js",
     "caml_external_polyfill.js",
     "caml_float_extern.js",
@@ -330,7 +322,6 @@
     "dom.js",
     "filename.js",
     "format.js",
-    "gc.js",
     "genlex.js",
     "hashtbl.js",
     "int32.js",
@@ -372,7 +363,6 @@
     "map.js",
     "marshal.js",
     "moreLabels.js",
-    "nativeint.js",
     "node_buffer.js",
     "node_child_process.js",
     "node_fs.js",
@@ -390,7 +380,6 @@
     "scanf.js",
     "set.js",
     "sort.js",
-    "spacetime.js",
     "stack.js",
     "std_exit.js",
     "stdLabels.js",
@@ -456,7 +445,6 @@
     "dom.cmi",
     "filename.cmi",
     "format.cmi",
-    "gc.cmi",
     "genlex.cmi",
     "hashtbl.cmi",
     "int32.cmi",
@@ -498,7 +486,6 @@
     "map.cmi",
     "marshal.cmi",
     "moreLabels.cmi",
-    "nativeint.cmi",
     "node_buffer.cmi",
     "node_child_process.cmi",
     "node_fs.cmi",
@@ -516,7 +503,6 @@
     "scanf.cmi",
     "set.cmi",
     "sort.cmi",
-    "spacetime.cmi",
     "stack.cmi",
     "std_exit.cmi",
     "stdLabels.cmi",
@@ -589,7 +575,6 @@
     "dom.cmt",
     "filename.cmt",
     "format.cmt",
-    "gc.cmt",
     "genlex.cmt",
     "hashtbl.cmt",
     "int32.cmt",
@@ -631,7 +616,6 @@
     "map.cmt",
     "marshal.cmt",
     "moreLabels.cmt",
-    "nativeint.cmt",
     "node_buffer.cmt",
     "node_child_process.cmt",
     "node_fs.cmt",
@@ -649,7 +633,6 @@
     "scanf.cmt",
     "set.cmt",
     "sort.cmt",
-    "spacetime.cmt",
     "stack.cmt",
     "std_exit.cmt",
     "stdLabels.cmt",
@@ -713,7 +696,6 @@
     "digest.cmti",
     "filename.cmti",
     "format.cmti",
-    "gc.cmti",
     "genlex.cmti",
     "hashtbl.cmti",
     "int32.cmti",
@@ -738,7 +720,6 @@
     "map.cmti",
     "marshal.cmti",
     "moreLabels.cmti",
-    "nativeint.cmti",
     "node_process.cmti",
     "obj.cmti",
     "parsing.cmti",
@@ -750,7 +731,6 @@
     "scanf.cmti",
     "set.cmti",
     "sort.cmti",
-    "spacetime.cmti",
     "stack.cmti",
     "stdLabels.cmti",
     "stream.cmti",
@@ -823,7 +803,6 @@
     "dom.ml",
     "filename.ml",
     "format.ml",
-    "gc.ml",
     "genlex.ml",
     "hashmap.cppo.ml",
     "hashset.cppo.ml",
@@ -873,7 +852,6 @@
     "mapm.cppo.ml",
     "marshal.ml",
     "moreLabels.ml",
-    "nativeint.ml",
     "node_buffer.ml",
     "node_child_process.ml",
     "node_fs.ml",
@@ -893,7 +871,6 @@
     "setm.cppo.ml",
     "sort.cppo.ml",
     "sort.ml",
-    "spacetime.ml",
     "stack.ml",
     "std_exit.ml",
     "stdLabels.ml",
@@ -958,7 +935,6 @@
     "digest.mli",
     "filename.mli",
     "format.mli",
-    "gc.mli",
     "genlex.mli",
     "hashmap.cppo.mli",
     "hashset.cppo.mli",
@@ -987,7 +963,6 @@
     "mapm.cppo.mli",
     "marshal.mli",
     "moreLabels.mli",
-    "nativeint.mli",
     "node_process.mli",
     "obj.mli",
     "parsing.mli",
@@ -1001,7 +976,6 @@
     "setm.cppo.mli",
     "sort.cppo.mli",
     "sort.mli",
-    "spacetime.mli",
     "stack.mli",
     "stdLabels.mli",
     "stream.mli",
@@ -1051,8 +1025,7 @@
   ],
   "vendor": [
     "ninja.tar.gz",
-    "ocaml.tar.gz",
-    "README.md"
+    "ocaml.tar.gz"
   ],
   "win32": [
     "ninja.COPYING",

jscomp/artifacts.json

@@ -62,7 +62,7 @@ let export_all = "all"
 let export_none = "none"
 
 
-let g_lib_incls = "g_lib_incls"
+
 let use_stdlib = "use-stdlib"
 let reason = "reason"
 let react_jsx = "react-jsx"

jscomp/bsb/bsb_build_schemas.ml

@@ -29,15 +29,15 @@ let (//) = Ext_path.combine
 let ninja_clean  proj_dir =
   try
     let cmd = Bsb_global_paths.vendor_ninja in
-    let lib_artifacts_dir = !Bsb_global_backend.lib_artifacts_dir in
+    let lib_artifacts_dir = Bsb_config.lib_bs in
     let cwd = proj_dir // lib_artifacts_dir in
     if Sys.file_exists cwd then
       let eid =
         Bsb_unix.run_command_execv {cmd ; args = [|cmd; "-t"; "clean"|] ; cwd} in
       if eid <> 0 then
-        Bsb_log.warn "@{<warning>ninja clean failed@}@."
+        Bsb_log.warn "@{<warning>Failed@}@."
   with  e ->
-    Bsb_log.warn "@{<warning>ninja clean failed@} : %s @." (Printexc.to_string e)
+    Bsb_log.warn "@{<warning>Failed@}: %s @." (Printexc.to_string e)
 
 let clean_bs_garbage proj_dir =
   Bsb_log.info "@{<info>Cleaning:@} in %s@." proj_dir ;