unused value warning -> error

Author: bobzhang

jscomp/bsb/bsb_config.ml

@@ -57,5 +57,5 @@ let proj_rel path = lazy_src_root_dir // path
 
 
 
-let cmd_package_specs = ref None 
+(* let cmd_package_specs = ref None  *)
 

jscomp/bsb/bsb_config_parse.ml

@@ -23,7 +23,7 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
 
-let get_list_string = Bsb_build_util.get_list_string
+(* let get_list_string = Bsb_build_util.get_list_string *)
 let (//) = Ext_path.combine
 let current_package : Bsb_pkg_types.t = Global Bs_version.package_name
 let resolve_package cwd  package_name = 
@@ -39,9 +39,9 @@ let (|?)  m (key, cb) =
   m  |> Ext_json.test key cb
 
 
-
-let extract_main_entries (map :json_map) =  
 #if BS_NATIVE then  
+let extract_main_entries (map :json_map) =  
+
   let extract_entries (field : Ext_json_types.t array) =
     Ext_array.to_list_map (function
         | Ext_json_types.Obj {map} ->
@@ -76,7 +76,7 @@ let extract_main_entries (map :json_map) =
     | _ -> ()
   end; !entries
 #else 
-  []  
+let extract_main_entries (_ :json_map) = []  
 #end
 
 

jscomp/bsb/bsb_db_util.ml

@@ -24,7 +24,7 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 type module_info = Bsb_db.module_info
 type t = Bsb_db.t
-type case = Bsb_db.case
+(* type case = Bsb_db.case *)
 
 
 

jscomp/bsb/bsb_log.ml

@@ -49,8 +49,8 @@ let color_functions : Format.formatter_tag_functions = {
   print_close_tag = (fun _ -> ())
 }
 
-let set_color ppf =
-  Format.pp_set_formatter_tag_functions ppf color_functions
+(* let set_color ppf =
+  Format.pp_set_formatter_tag_functions ppf color_functions *)
 
 
 let setup () = 

jscomp/bsb/bsb_merlin_gen.ml

@@ -110,7 +110,7 @@ let merlin_file_gen ~per_proj_dir:(per_proj_dir:string)
       external_includes; 
       reason_react_jsx ; 
       namespace;
-      package_name;
+      package_name = _;
       warning; 
      } : Bsb_config_types.t)
   =

jscomp/bsb/bsb_ninja_gen.ml

@@ -31,7 +31,7 @@ let (//) = Ext_path.combine
 
 
 
-let dash_i = "-I"
+(* let dash_i = "-I" *)
 
 
 
@@ -184,8 +184,8 @@ let output_ninja_and_namespace_map
       Bsb_db_util.sanity_check bs_group;
       [|bs_group|], source_dirs, static_resources
     else
-      let bs_groups = Array.init  (number_of_dev_groups + 1 ) (fun i -> Map_string.empty) in
-      let source_dirs = Array.init (number_of_dev_groups + 1 ) (fun i -> []) in
+      let bs_groups = Array.init  (number_of_dev_groups + 1 ) (fun _ -> Map_string.empty) in
+      let source_dirs = Array.init (number_of_dev_groups + 1 ) (fun _ -> []) in
       let static_resources =
         Ext_list.fold_left bs_file_groups [] (fun (acc_resources : string list) {sources; dir; resources; dir_index} 
            ->

jscomp/bsb/bsb_parse_sources.ml

@@ -28,7 +28,7 @@ type build_generator = Bsb_file_groups.build_generator
 
 
 
-type file_group = Bsb_file_groups.file_group
+(* type file_group = Bsb_file_groups.file_group *)
 
 type t = Bsb_file_groups.t 
 
@@ -134,7 +134,7 @@ type json_map = Ext_json_types.t Map_string.t
 
 let extract_generators (input : json_map) : build_generator list  =
   match Map_string.find_opt input  Bsb_build_schemas.generators with
-  | Some (Arr { content ; loc_start}) ->
+  | Some (Arr { content ; loc_start= _}) ->
     (* Need check is dev build or not *)
     Ext_array.fold_left content [] (fun acc x ->
         match x with
@@ -294,7 +294,7 @@ let rec
               Bsb_db_util.add_basename ~dir acc basename ~error_on_invalid_suffix:loc
             | _ -> acc
           ) 
-      | Some (Obj {map = map; loc} ) -> (* { excludes : [], slow_re : "" }*)
+      | Some (Obj {map = map; loc = _} ) -> (* { excludes : [], slow_re : "" }*)
         let predicate = extract_predicate map in 
         Ext_array.fold_left (Lazy.force base_name_array) output_sources (fun acc basename -> 
             if is_input_or_output scanned_generators basename || not (predicate basename) then acc 

jscomp/bsb/bsb_unix.ml

@@ -49,7 +49,7 @@ let run_command_execv_unix  cmd : int =
     Unix.execv cmd.cmd cmd.args 
   | pid -> 
     match Unix.waitpid [] pid  with 
-    | pid, process_status ->       
+    | _, process_status ->       
       match process_status with 
       | Unix.WEXITED eid ->
         eid    

jscomp/bsb/bsb_world.ml

@@ -28,7 +28,7 @@ let (//) = Ext_path.combine
 (** TODO: create the animation effect 
     logging installed files
 *)
-let install_targets cwd ({files_to_install; namespace; package_name} : Bsb_config_types.t ) =  
+let install_targets cwd ({files_to_install; namespace; package_name = _} : Bsb_config_types.t ) =  
   let install ~destdir file = 
      Bsb_file.install_if_exists ~destdir file  |> ignore
   in

jscomp/bsb_helper/bsb_helper_dep_graph.ml

@@ -98,7 +98,7 @@ let get_otherlibs_dependencies dependency_graph file_extension =
     else
       acc
   in
-  let set_of_otherlib_deps = Map_string.fold dependency_graph Set_string.empty (fun k v acc ->
+  let set_of_otherlib_deps = Map_string.fold dependency_graph Set_string.empty (fun _k v acc ->
     let addIfPresent = addIfPresentInSet v in
     acc
       |> addIfPresent "Unix"     "unix"

jscomp/bsb_helper/bsb_helper_depfile_gen.ml

@@ -80,12 +80,12 @@ let deps_of_channel (ic : in_channel) : string list =
     mostly for cutting the dependency so that [bsb_helper.exe] does
     not depend on compler-libs
 *)
-let read_deps (fn : string) : string list = 
+(* let read_deps (fn : string) : string list = 
   let ic = open_in_bin fn in 
   let v = deps_of_channel ic in 
   close_in ic;
   v
-
+ *)
 
 type kind = Js | Bytecode | Native
 

jscomp/common/lam_methname.ml

@@ -131,7 +131,7 @@ let valid_start_char x =
   match x with 
   | '_' | 'a' .. 'z' -> true 
   | _ -> false 
-let translate ?loc name = 
+let translate name = 
   assert (not @@ Ext_string.is_empty name);
   let i = Ext_string.rfind ~sub:double_underscore name in 
   if i < 0 then 

jscomp/common/lam_methname.mli

@@ -24,4 +24,5 @@
 
 
 
-val translate : ?loc:Location.t -> string -> string
+val translate : 
+  string -> string

jscomp/core/js_analyzer.ml

@@ -182,12 +182,12 @@ let rec eq_expression
         | Number (Int j)   -> i = j 
         | _ -> false 
       end
-    | Number (Float i) -> 
-      begin match y0 with 
+    | Number (Float _) -> false
+      (* begin match y0 with 
         | Number (Float j) ->
           false (* conservative *)
         | _ -> false 
-      end    
+      end     *)
     | String_index (a0,a1) -> 
       begin match y0 with 
         | String_index(b0,b1) -> 
@@ -358,7 +358,7 @@ let rec is_constant (x : J.expression)  =
   | Array (xs,_mutable_flag)  -> Ext_list.for_all xs  is_constant 
   | Caml_block(xs, Immutable, tag, _) 
     -> Ext_list.for_all xs is_constant && is_constant tag 
-  | Bin (op, a, b) -> 
+  | Bin (_op, a, b) -> 
     is_constant a && is_constant b     
   | _ -> false 
 

jscomp/core/js_ast_util.ml

@@ -27,12 +27,12 @@
 
 
 
-module E = Js_exp_make 
+(* module E = Js_exp_make  *)
 
 module S = Js_stmt_make  
 
 
-let rec named_expression (e : J.expression)
+let named_expression (e : J.expression)
   :  (J.statement  * Ident.t) option = 
   if Js_analyzer.is_okay_to_duplicate e then 
     None 

jscomp/core/js_cmj_format.ml

@@ -54,7 +54,7 @@ type t = {
   npm_package_path : Js_packages_info.t ;
   cmj_case : cmj_case; 
 }
-let empty_values = [||]
+(* let empty_values = [||] *)
 let mk ~values ~effect ~npm_package_path ~cmj_case : t = 
   {
     values = Map_string.to_sorted_array values; 
@@ -108,7 +108,7 @@ let from_string s : t =
 
 let fixed_length = cmj_magic_number_length + digest_length
 
-let rec for_sure_not_changed (name : string) (header : string) =   
+let for_sure_not_changed (name : string) (header : string) =   
   if Sys.file_exists name then 
     let ic = open_in_bin name in 
     let holder =

jscomp/core/js_dump.ml

@@ -53,7 +53,7 @@
 
 module P = Ext_pp
 module E = Js_exp_make
-module S = Js_stmt_make
+(* module S = Js_stmt_make *)
 
 module L = Js_dump_lit
 
@@ -226,12 +226,12 @@ let pp_paren_params
 
 (** Print as underscore for unused vars, may not be 
     needed in the future *)  
-let ipp_ident cxt f id (un_used : bool) =
+(* let ipp_ident cxt f id (un_used : bool) =
   Ext_pp_scope.ident cxt f (
     if un_used then
       Ext_ident.make_unused () 
     else
-      id)
+      id) *)
 
 let pp_var_assign cxt f id  =       
   P.string f L.var ; 
@@ -279,9 +279,10 @@ let comma_sp f =
 let comma_nl f = 
   comma f ; P.newline f 
 
-let drop_comment (x : J.expression) = 
+(* let drop_comment (x : J.expression) = 
   if x.comment = None then x 
-  else {x with comment = None}  
+  else {x with comment = None}   *)
+
 let debugger_nl f =   
   P.newline f ; 
   P.string f L.debugger;
@@ -300,7 +301,8 @@ let continue f s =
   P.string f s;
   semi f
 
-let formal_parameter_list cxt f offset l env  = 
+
+let formal_parameter_list cxt f  l   = 
     iter_lst cxt f l Ext_pp_scope.ident comma_sp 
 (* IdentMap *)
 (*
@@ -406,7 +408,7 @@ and  pp_function is_method
         | [] -> assert false 
         | this::arguments -> 
           let cxt = P.paren_group f 1 (fun _ ->
-              formal_parameter_list inner_cxt  f 1 arguments env )
+              formal_parameter_list inner_cxt  f  arguments )
           in
           P.space f ;
           P.brace_vgroup f 1 (fun _ ->
@@ -417,7 +419,7 @@ and  pp_function is_method
             );
       else 
         let cxt = 
-          P.paren_group f 1 (fun _ -> formal_parameter_list inner_cxt  f 0 l env ) in
+          P.paren_group f 1 (fun _ -> formal_parameter_list inner_cxt  f  l  ) in
         P.space f ;
         P.brace_vgroup f 1 (fun _ -> function_body cxt f b ) 
     in
@@ -1014,7 +1016,7 @@ and variable_declaration top cxt f
         cxt
 
 
-and ipp_comment : 'a . P.t -> 'a  -> unit = fun   f comment ->
+and ipp_comment : 'a . P.t -> 'a  -> unit = fun   _f _comment ->
   ()
 
 

jscomp/core/js_dump_lit.ml

@@ -25,7 +25,7 @@
 let function_ = "function"
 let var = "var" (* should be able to switch to [let] easily*)
 let return = "return"
-let eq = "="
+(* let eq = "=" *)
 let require = "require"
 let import = "import"
 let from = "from"