add an indirection to register to avoid name pollution in the future

Author: bobzhang

Diff for: jscomp/runtime/caml_external_polyfill.ml

@@ -39,4 +39,12 @@ let resolve  = fun%raw s -> {|
   return myGlobal[s]
 |}
 
+(* FIXME: it does not have to global states *)
+type fn 
 
+
+let register : string -> fn -> unit = fun%raw s fn -> {|
+  var myGlobal = getGlobalThis();
+  myGlobal[s] = fn 
+  return 0
+|}

Diff for: jscomp/test/external_polyfill_test.js

@@ -12,9 +12,9 @@ function eq(loc, x, y) {
 }
 
 
-global.caml_fancy_add= function(x,y){
+require('../../lib/js/caml_external_polyfill.js').register("caml_fancy_add", function(x,y){
   return + ((""+x ) + (""+y))
-}
+})
 
 ;
 

Diff for: jscomp/test/external_polyfill_test.ml

@@ -7,9 +7,9 @@ external ff : int -> int -> int = "caml_fancy_add"
 
 
 [%%raw{|
-global.caml_fancy_add= function(x,y){
+require('../../lib/js/caml_external_polyfill.js').register("caml_fancy_add", function(x,y){
   return + ((""+x ) + (""+y))
-}
+})
 |}]
 
 

Diff for: lib/js/caml_external_polyfill.js

@@ -18,6 +18,13 @@ function resolve (s){
   return myGlobal[s]
 };
 
+function register (s,fn){
+  var myGlobal = getGlobalThis();
+  myGlobal[s] = fn 
+  return 0
+};
+
 exports.getGlobalThis = getGlobalThis;
 exports.resolve = resolve;
+exports.register = register;
 /* No side effect */