code cleanup

Author: loiane

src/ts/others/balanced-symbols.ts

@@ -10,7 +10,7 @@ export function parenthesesChecker(symbols: string) {
   let top: string;
 
   while (index < symbols.length && balanced) {
-    symbol = symbols.charAt(index);
+    symbol = symbols[index];
     if (opens.indexOf(symbol) >= 0) {
       stack.push(symbol);
       // console.log(`open symbol - stacking ${symbol}`);
@@ -36,8 +36,5 @@ export function parenthesesChecker(symbols: string) {
     }
     index++;
   }
-  if (balanced && stack.isEmpty()) {
-    return true;
-  }
-  return false;
+  return balanced && stack.isEmpty();
 }

src/ts/others/fibonacci.ts

@@ -22,7 +22,7 @@ export function fibonacciMemoization(n: number) {
   if (n < 1) { return 0; }
   const memo = [0, 1];
   const fibonacciMem = (num: number): number => {
-    if (memo[num] != null) { return memo[num]; }
+    // if (memo[num] != null) { return memo[num]; }
     return (memo[num] = fibonacciMem(num - 1) + fibonacciMem(num - 2));
   };
   return fibonacciMem(n);

src/ts/util.ts

@@ -24,7 +24,7 @@ export function biggerEquals<T>(a: T, b: T, compareFn: ICompareFunction<T>) {
 
 export function defaultCompare<T>(a: T, b: T): number {
   if (a === b) {
-    return 0;
+    return Compare.EQUALS;
   }
   return a < b ? Compare.LESS_THAN : Compare.BIGGER_THAN;
 }