Fix PHP 8.1 deprecation warning for NULL on_behalf_of_user

Spice-King · mgruner · commit ea8f680f8bcd · 2022-07-28T14:17:04.000+02:00
Fixes #49, empty handles both null and empty string just fine
diff --git a/src/Client.php b/src/Client.php
@@ -72,7 +72,7 @@ private function request ( $method, $url, array $url_parameters = [], array $opt
         $options['headers']['Content-Type'] = 'application/json; charset=utf-8';
 
         // Set "on behalf of user" header
-        if ( mb_strlen($this->on_behalf_of_user) ) {
+        if ( !empty($this->on_behalf_of_user) ) {
             $options['headers']['X-On-Behalf-Of'] = $this->on_behalf_of_user;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ private function request ( $method, $url, array $url_parameters = [], array $opt`
`72`	`72`	`$options['headers']['Content-Type'] = 'application/json; charset=utf-8';`
`73`	`73`
`74`	`74`	`// Set "on behalf of user" header`
`75`		`- if ( mb_strlen($this->on_behalf_of_user) ) {`
	`75`	`+ if ( !empty($this->on_behalf_of_user) ) {`
`76`	`76`	`$options['headers']['X-On-Behalf-Of'] = $this->on_behalf_of_user;`
`77`	`77`	`}`
`78`	`78`