Skip to content

Commit dc577fc

Browse files
committed
Merge remote-tracking branch 'yudao/feature/bpm' into feature/bpm-子流程
2 parents 64ff45e + b0d839a commit dc577fc

File tree

5 files changed

+16
-5
lines changed

5 files changed

+16
-5
lines changed

src/components/SimpleProcessDesignerV2/src/consts.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ export enum TriggerTypeEnum {
756756
* 发送 HTTP 请求触发器
757757
*/
758758
HTTP_REQUEST = 1,
759+
// TODO @jason:要不把 FORM_UPDATE、FORM_DELETE 调整从 10、11 这样?
759760
/**
760761
* 表单数据更新触发器
761762
*/
@@ -764,6 +765,7 @@ export enum TriggerTypeEnum {
764765
* 表单数据删除触发器
765766
*/
766767
FORM_DELETE = 3,
768+
// TODO @jason:1)HTTP_CALLBACK 这个枚举值?然后,相关注释,朝着“HTTP 回调”走;2)枚举值改成 2?
767769
/**
768770
* 发起异步 HTTP 请求
769771
*/
@@ -795,7 +797,7 @@ export type FormTriggerSetting = {
795797
// 条件组
796798
conditionGroups?: ConditionGroup
797799
// 更新表单字段配置
798-
updateFormFields?: Record<string, any>,
800+
updateFormFields?: Record<string, any>
799801
// 删除表单字段配置
800802
deleteFields?: string[]
801803
}

src/components/SimpleProcessDesignerV2/src/nodes-config/ChildProcessNodeConfig.vue

+5
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
<Icon icon="ep:plus" class="mr-5px" />添加一行
104104
</el-button>
105105
</el-form-item>
106+
<!-- TODO @lesan:async、source、target 几个字段,会告警 -->
106107
<el-form-item
107108
v-if="configForm.async === false"
108109
label="子→主变量传递"
@@ -159,6 +160,7 @@
159160
<Icon icon="ep:plus" class="mr-5px" />添加一行
160161
</el-button>
161162
</el-form-item>
163+
<!-- TODO @lesan:startUserType、startUserEmptyType 要不走写下枚举类? -->
162164
<el-form-item label="子流程发起人" prop="startUserType">
163165
<el-radio-group v-model="configForm.startUserType">
164166
<el-radio :value="1">同主流程发起人</el-radio>
@@ -332,6 +334,7 @@ const saveConfig = async () => {
332334
if (!formRef) return false
333335
const valid = await formRef.value.validate()
334336
if (!valid) return false
337+
// TODO @lesan:这里的 option 黄色告警,也处理下哈
335338
const childInfo = childProcessOptions.value.find(
336339
(option) => option.key === configForm.value.calledProcessDefinitionKey
337340
)
@@ -375,6 +378,7 @@ const saveConfig = async () => {
375378
return true
376379
}
377380
// 显示子流程节点配置, 由父组件传过来
381+
// TODO @lesan:inVariables、outVariables 红色告警
378382
const showChildProcessNodeConfig = (node: SimpleFlowNode) => {
379383
nodeName.value = node.name
380384
if (node.childProcessSetting) {
@@ -417,6 +421,7 @@ const showChildProcessNodeConfig = (node: SimpleFlowNode) => {
417421
418422
defineExpose({ openDrawer, showChildProcessNodeConfig }) // 暴露方法给父组件
419423
424+
// TODO @lesan:这里的 arr 黄色告警,也处理下哈,可以用 cursor quick fix 哈
420425
const addVariable = (arr) => {
421426
arr.push({
422427
source: '',

src/components/SimpleProcessDesignerV2/src/nodes-config/TriggerNodeConfig.vue

+5-3
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
</el-select>
3737
</el-form-item>
3838
<!-- HTTP 请求触发器 -->
39+
<!-- TODO @jason:可以考虑用 [].include 更简洁 -->
3940
<div
4041
v-if="
4142
(configForm.type === TriggerTypeEnum.HTTP_REQUEST ||
@@ -404,11 +405,12 @@ const changeTriggerType = () => {
404405
}
405406
configForm.value.formSettings = undefined
406407
return
407-
}
408-
408+
}
409+
409410
if (configForm.value.type === TriggerTypeEnum.ASYNC_HTTP_REQUEST) {
410411
configForm.value.httpRequestSetting =
411-
originalSetting?.type === TriggerTypeEnum.ASYNC_HTTP_REQUEST && originalSetting.httpRequestSetting
412+
originalSetting?.type === TriggerTypeEnum.ASYNC_HTTP_REQUEST &&
413+
originalSetting.httpRequestSetting
412414
? originalSetting.httpRequestSetting
413415
: {
414416
url: '',

src/components/SimpleProcessDesignerV2/src/nodes/ChildProcessNode.vue

+2
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ import { SimpleFlowNode, NodeType, NODE_DEFAULT_TEXT } from '../consts'
6666
import NodeHandler from '../NodeHandler.vue'
6767
import { useNodeName2, useWatchNode, useTaskStatusClass } from '../node'
6868
import ChildProcessNodeConfig from '../nodes-config/ChildProcessNodeConfig.vue'
69+
6970
defineOptions({
7071
name: 'ChildProcessNode'
7172
})
@@ -86,6 +87,7 @@ const currentNode = useWatchNode(props)
8687
// 节点名称编辑
8788
const { showInput, blurEvent, clickTitle } = useNodeName2(currentNode, NodeType.CHILD_PROCESS_NODE)
8889
const nodeSetting = ref()
90+
8991
// 打开节点配置
9092
const openNodeConfig = () => {
9193
if (readonly) {

src/views/bpm/processInstance/create/ProcessDefinitionDetail.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ const initProcessInfo = async (row: any, formVariables?: any) => {
157157
}
158158
159159
/** 预测流程节点会因为输入的参数值而产生新的预测结果值,所以需重新预测一次 */
160-
// TODO @芋艿:这里我执行填写表单的时候不知道为啥一直报错,先注释了
160+
// TODO @芋艿:这里我执行填写表单的时候不知道为啥一直报错,先注释了 @lesan:可以和群里的小北说下
161161
// watch(
162162
// detailForm.value,
163163
// (newValue) => {

0 commit comments

Comments
 (0)