【代码评审】BPM：触发器 HTTP 异步

Author: YunaiV

src/components/SimpleProcessDesignerV2/src/consts.ts

@@ -756,6 +756,7 @@ export enum TriggerTypeEnum {
    * 发送 HTTP 请求触发器
    */
   HTTP_REQUEST = 1,
+  // TODO @jason：要不把 FORM_UPDATE、FORM_DELETE 调整从 10、11 这样？
   /**
    * 表单数据更新触发器
    */
@@ -764,6 +765,7 @@ export enum TriggerTypeEnum {
    * 表单数据删除触发器
    */
   FORM_DELETE = 3,
+  // TODO @jason：1）HTTP_REQUEST_ASYNC 这个枚举值？；2）枚举值改成 2？；3）【有点纠结，微信讨论】异步是里面加个属性 async 属性，还是作为单独的枚举值。
   /**
    * 发起异步 HTTP 请求
    */
@@ -795,7 +797,7 @@ export type FormTriggerSetting = {
   // 条件组
   conditionGroups?: ConditionGroup
   // 更新表单字段配置
-  updateFormFields?: Record<string, any>,
+  updateFormFields?: Record<string, any>
   // 删除表单字段配置
   deleteFields?: string[]
 }
@@ -813,11 +815,11 @@ export const TRIGGER_TYPES: DictDataVO[] = [
 export type ChildProcessSetting = {
   calledProcessDefinitionKey: string
   calledProcessDefinitionName: string
-  async: boolean,
-  inVariables?: IOParameter[],
-  outVariables?: IOParameter[],
-  skipStartUserNode: boolean,
-  startUserSetting: StartUserSetting,
+  async: boolean
+  inVariables?: IOParameter[]
+  outVariables?: IOParameter[]
+  skipStartUserNode: boolean
+  startUserSetting: StartUserSetting
 }
 
 export type IOParameter = {

src/components/SimpleProcessDesignerV2/src/nodes-config/TriggerNodeConfig.vue

@@ -36,6 +36,7 @@
           </el-select>
         </el-form-item>
         <!-- HTTP 请求触发器 -->
+        <!-- TODO @jason：可以考虑用 [].include 更简洁 -->
         <div
           v-if="
             (configForm.type === TriggerTypeEnum.HTTP_REQUEST ||
@@ -404,11 +405,12 @@ const changeTriggerType = () => {
           }
     configForm.value.formSettings = undefined
     return
-  } 
-  
+  }
+
   if (configForm.value.type === TriggerTypeEnum.ASYNC_HTTP_REQUEST) {
     configForm.value.httpRequestSetting =
-      originalSetting?.type === TriggerTypeEnum.ASYNC_HTTP_REQUEST && originalSetting.httpRequestSetting
+      originalSetting?.type === TriggerTypeEnum.ASYNC_HTTP_REQUEST &&
+      originalSetting.httpRequestSetting
         ? originalSetting.httpRequestSetting
         : {
             url: '',