Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add database hyperlink to logging service #2021

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Mar 17, 2025

Closes #1783

Will look like this:

Screenshot 2025-03-17 at 19 24 13 Screenshot 2025-03-17 at 19 23 23

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
264 263 0 0 1
Test Changes Summary ⏭️1

⏭️ Skipped Tests (1)

  1. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 83.22 MB | Main: 83.21 MB
Diff: +5.87 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for linking to database logs by introducing a new LogsButton component and propagating a getLogsLink function through various tenant and cluster components.

  • Introduces a new LogsButton in src/components/LogsButton/LogsButton.tsx
  • Updates additional properties, tenant and cluster components, and application routing to support a logs hyperlink
  • Expands type definitions and monitoring utilities to include the logs link functionality

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/LogsButton/LogsButton.tsx Introduces a new button component for linking to database logs
src/utils/monitoring.ts Adds the GetLogsLink interface and type for logs hyperlink generation
src/components/TenantNameWrapper/TenantNameWrapper.tsx Adjusts the popover condition to include logsLink
src/containers/AppWithClusters/ExtendedTenant/ExtendedTenant.tsx Propagates and utilizes the new getLogsLink property
src/containers/AppWithClusters/ExtendedCluster/ExtendedCluster.tsx Updates additional tenants properties to include getLogsLink
src/containers/AppWithClusters/AppWithClusters.tsx Passes getLogsLink to extended cluster and tenant components
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx Adds LogsButton to the diagnostics view if a logs link is available
src/types/additionalProps.ts Extends type definitions with getLogsLink for tenant additional properties
Files not reviewed (2)
  • src/components/TenantNameWrapper/i18n/en.json: Language not supported
  • src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.scss: Language not supported
Comments suppressed due to low confidence (1)

src/types/additionalProps.ts:18

  • The type signature for getLogsLink in AdditionalTenantsProps does not match its usage and the definition in src/utils/monitoring.ts. Consider updating it to accept an object with dbName and clusterName, or aligning both usages for consistency.
getLogsLink?: (name?: string) => string | null;
@astandrik astandrik added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit dbab46b Mar 18, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.1783 branch March 18, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add database hyperlink to logging service
2 participants