feat: add ShardsTable to componentsRegistry #1993
Merged
+228
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1923-shards-table-to-registry
branch
from
8a2f251 to
b2f2580
Compare
artemmufazalov
force-pushed
the
1923-shards-table-to-registry
branch
2 times, most recently
from
83251a8 to
b8af488
Compare
sareyu
previously approved these changes
Mar 10, 2025
| .map((column) => { | ||
| return { | ||
| ...column, | ||
| sortable: isSortableTopShardsColumn(column.name), |
There was a problem hiding this comment.
maybe add this prop in previous map cycle?
| () => | ||
| columnsIds | ||
| .map((id) => { | ||
| return shardsColumnIdToGetColumn[id]({database, schemaPath}); |
There was a problem hiding this comment.
maybe add a check for shardsColumnIdToGetColumn[id] existence?
sareyu
previously approved these changes
Mar 10, 2025
artemmufazalov
force-pushed
the
1923-shards-table-to-registry
branch
from
ff52974 to
219fd59
Compare
sareyu
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: 🔽
Current: 83.21 MB | Main: 83.30 MB
Diff: 0.09 MB (-0.10%)
✅ Bundle size decreased.
ℹ️ CI Information