Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation modal "You have unsaved changes in query editor" is annoying #1984

Closed
perfilyev opened this issue Feb 25, 2025 · 1 comment · Fixed by #2026
Closed

Confirmation modal "You have unsaved changes in query editor" is annoying #1984

perfilyev opened this issue Feb 25, 2025 · 1 comment · Fixed by #2026
Assignees
@astandrik
Labels
area/ux Issues to improve UX. Mainly research follow-ups feedback 🐞 type/bug Something isn't working

Comments

@perfilyev
Copy link
Collaborator

Use case: switch between saved queries. I don't need this confirmation every time I switch between saved queries or queries from history - especially when I don't change these queries.

Image
@antonkovalenko
Copy link
Member

antonkovalenko commented Mar 10, 2025 •
edited
Loading

It's a bug
When query text was not change we must never ask for confirmation
even when the query was run before choosing another one

@antonkovalenko antonkovalenko added 🐞 type/bug Something isn't working area/ux Issues to improve UX. Mainly research follow-ups feedback labels Mar 10, 2025
@astandrik astandrik mentioned this issue Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astandrik astandrik

Labels
area/ux Issues to improve UX. Mainly research follow-ups feedback 🐞 type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unsaved changes in query editor ydb-platform/ydb-embedded-ui
3 participants
@antonkovalenko @perfilyev @astandrik