Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ObjectSummary): refresh tabs with tree refresh, disable autorefresh #1946

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Feb 13, 2025

Closes #1906

  • Do not autorefresh Preview
  • Do not autorefresh Overview, ACL and Schema
  • Refresh Overview, ACL and Schema with tree refresh button

Overview and Schema are still affected by Diagnostics manual refresh, since the same apis are used in Diagnostics. It does not make much difference since we refresh overviewApi in Diagnostics anyway (it is used in Tenant component). The only unneeded refresh is viewSchema - if it is opened in left panel, it will be refreshed by Diagnostics manual refresh since this api used both in schema tabs in diagnostics. I did not find a simple solution that prevents it, so I would leave it as before, as for me this case is rare enough, while request is not heavy (select * limit 0)

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
262 262 0 0 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 80.32 MB | Main: 80.32 MB
Diff: +0.12 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

pollingInterval: autoRefreshInterval,
},
);
} = overviewApi.useGetOverviewQuery({path, database: tenantName});
Copy link
Member Author

@artemmufazalov artemmufazalov Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We make this request to receive schema object types (they are not changed unless object is deleted and new object with the same name is created) and check access rights, so we don't need autorefresh here (but it is still refreshed by manual refresh)

@artemmufazalov artemmufazalov marked this pull request as ready for review February 14, 2025 08:33
@artemmufazalov artemmufazalov added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit c28ade6 Feb 18, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 1906-tree-tabs-refresh branch February 18, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autorefresh on query tab keeps refreshing diagnostics (describe)
2 participants