fix: code assistant option #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
previously approved these changes
Feb 10, 2025
|
@Raubzeug used factory instance creation instead of hook for register/unregister functionality @artemmufazalov - you may find it interesting to take a glance |
Raubzeug
requested changes
Feb 11, 2025
| React.useEffect(() => { | ||
| if (monacoGhostInstance && isCodeAssistEnabled) { | ||
| monacoGhostInstance.register(monacoGhostConfig); | ||
| prepareUserQueriesCache(); |
There was a problem hiding this comment.
Should we prepare cache every time any useEffect dependency changes?
| @@ -45,8 +46,11 @@ export function YqlEditor({ | |||
| }: YqlEditorProps) { | |||
| const input = useTypedSelector(selectUserInput); | |||
| const dispatch = useTypedDispatch(); | |||
| const [monacoGhostInstance, setMonacoGhostInstance] = | |||
There was a problem hiding this comment.
let's not use state for editor instance? Will window.ydbEditor be enough?
Raubzeug
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.32 MB | Main: 80.32 MB
Diff: +4.10 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information