feat(Node): rework page #1917
Merged
feat(Node): rework page #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1339-rework-node-page
branch
2 times, most recently
from
452a4f1 to
acaa30a
Compare
artemmufazalov
commented
Feb 7, 2025
| import {useAdditionalNodeProps} from '../useClusterData'; | ||
|
|
||
| export function ExtendedNode({component: NodeComponent}: {component: typeof Node}) { | ||
| const {balancer} = useClusterBaseInfo(); |
There was a problem hiding this comment.
This was moved to useNodeDeveloperUIHref, there is no need for this wrapper anymore
artemmufazalov
commented
Feb 7, 2025
| @@ -25,7 +25,6 @@ const routes = { | |||
| vDisk: `/${VDISK}`, | |||
| storageGroup: `/${STORAGE_GROUP}`, | |||
| tablet: `/${TABLET}/:id`, | |||
| tabletsFilters: `/tabletsFilters`, | |||
There was a problem hiding this comment.
Old path, there is no page for this path now
artemmufazalov
force-pushed
the
1339-rework-node-page
branch
from
acaa30a to
f1aacd3
Compare
artemmufazalov
force-pushed
the
1339-rework-node-page
branch
from
f1aacd3 to
861afab
Compare
Raubzeug
requested changes
Feb 10, 2025
src/containers/Node/Node.tsx
Outdated
| useRouteMatch<{id: string; activeTab: string}>(routes.node) ?? Object.create(null); | ||
| const match = useRouteMatch<{id: string; activeTab: string}>(routes.node); | ||
|
|
||
| // NodeId is always defined here because the page is wrapped with specific route Router |
There was a problem hiding this comment.
Let's better add a straightforward check, so no changes in Router api could affect our code.
src/containers/Node/Node.tsx
Outdated
|
|
||
| return {activeTabVerified: actualActiveTab, nodeTabs: actualNodeTabs}; | ||
| }, [activeTab, node, isDiskPagesAvailable]); | ||
| const renderHelmet = () => { |
There was a problem hiding this comment.
what if to move every render function to a separate component (like https://github.com/ydb-platform/ydb-embedded-ui/blob/861afab08d02e8ac481ec5d1f36035bd5eed92f3/src/containers/Tablet/Tablet.tsx ) ?
Raubzeug
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1339
Make node page look similar to other pages
Stand: https://nda.ya.ru/t/h85Fpl3x7BmekR
Before:
After:
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔽
Current: 80.21 MB | Main: 80.26 MB
Diff: 0.05 MB (-0.07%)
✅ Bundle size decreased.
ℹ️ CI Information