fix(SchemaViewer): use partitioning keys order from HashColumns #1916
Conversation
artemmufazalov
force-pushed
the
partitioning-keys-order
branch
from
f8f630f to
09d7cf0
Compare
| .filter((row): row is WithRequiredFields<SchemaData, 'keyColumnIndex' | 'name'> => | ||
| Boolean(row.keyColumnIndex !== undefined && row.keyColumnIndex !== -1 && row.name), | ||
| ) | ||
| .sort((column1, column2) => column1.keyColumnIndex - column2.keyColumnIndex) | ||
| .map((row) => row.name); |
There was a problem hiding this comment.
Update types to remove non-null assertions
| .filter((row): row is WithRequiredFields<SchemaData, 'partitioningColumnIndex' | 'name'> => | ||
| Boolean( | ||
| row.partitioningColumnIndex !== undefined && | ||
| row.partitioningColumnIndex !== -1 && | ||
| row.name, | ||
| ), | ||
| ) | ||
| .sort( | ||
| (column1, column2) => column1.partitioningColumnIndex - column2.partitioningColumnIndex, | ||
| ) | ||
| .map((row) => row.name); |
There was a problem hiding this comment.
Implemented sorting the same way as in getPrimaryKeys
| Indexes?: unknown; | ||
| Options?: TColumnTableSchemeOptions; | ||
| ColumnFamilies?: TFamilyDescription[]; |
There was a problem hiding this comment.
Updated types, set unknown to types, that are not used currently. The goal was to use backend response as is in tests without any TS errors
| it('returns empty array if data is undefined, empty or null', () => { | ||
| expect(prepareSchemaData(EPathType.EPathTypeTable, {})).toEqual([]); | ||
| expect(prepareSchemaData(EPathType.EPathTypeTable, undefined)).toEqual([]); | ||
| expect(prepareSchemaData(EPathType.EPathTypeTable, null)).toEqual([]); | ||
| }); |
There was a problem hiding this comment.
There is no external tables in our dev clusters and there is no possibility to add them since feature flag is turned off and there is issue with flags. I didn't want to use generated response instead of real backend data, so I left external tables without tests for now
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/containers/Tenant/Schema/SchemaViewer/prepareData.ts: Evaluated as low risk
- src/containers/Tenant/Schema/SchemaViewer/types.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/types/api/schema/columnEntity.ts:84
- [nitpick] The use of 'unknown' for 'Indexes' might be too vague. Consider specifying a more concrete type if possible.
Indexes?: unknown;
|
fixed this test Tenant diagnostics page is visible when describe returns no data |
Closes ydb-platform/ydb#14247
CI Results
Test Status: ❌ FAILED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.20 MB | Main: 80.20 MB
Diff: +0.81 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information