Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new json viewer #1388

Closed
Raubzeug opened this issue Oct 2, 2024 · 0 comments · Fixed by #1951
Closed

Move to new json viewer #1388

Raubzeug opened this issue Oct 2, 2024 · 0 comments · Fixed by #1951
Assignees
Labels
🏎️ area/performance Make UI faster 🛠️ area/tech-debt Tasks to update some code that could slow down development prio/medium size/xl

Comments

@Raubzeug
Copy link
Contributor

Raubzeug commented Oct 2, 2024

For now it is used react-json-inspector, which is not supported from 2015 year and has issues with performance. Also it doesn't support virtualization and dies on big json's.
YTSaurus implementation has all needed features (virtualization, search).

Plan of adoption:

  1. Copy-paste code to ydb-embedded-ui (https://github.com/ytsaurus/ytsaurus-ui/tree/main/packages/ui/src/ui/components/Yson/StructuredYsonVirtualized)
  2. Test a couple of months
  3. Move component to @gravity-ui/uikit and use it in ydb-embedded-ui and ytsaurus-ui.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏎️ area/performance Make UI faster 🛠️ area/tech-debt Tasks to update some code that could slow down development prio/medium size/xl
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants