Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Commit 7478e24

Browse files
gaearonwmonk
authored andcommittedAug 7, 2017
Don't run yarn after ejecting (#2634)
1 parent d585b5a commit 7478e24

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed
 

‎packages/react-scripts/scripts/eject.js

+15-2
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,21 @@ inquirer
220220
}
221221

222222
if (fs.existsSync(paths.yarnLockFile)) {
223-
console.log(cyan('Running yarn...'));
224-
spawnSync('yarnpkg', [], { stdio: 'inherit' });
223+
// TODO: this is disabled for three reasons.
224+
//
225+
// 1. It produces garbage warnings on Windows on some systems:
226+
// https://github.com/facebookincubator/create-react-app/issues/2030
227+
//
228+
// 2. For the above reason, it breaks Windows CI:
229+
// https://github.com/facebookincubator/create-react-app/issues/2624
230+
//
231+
// 3. It is wrong anyway: re-running yarn will respect the lockfile
232+
// rather than package.json we just updated. Instead we should have
233+
// updated the lockfile. So we might as well not do it while it's broken.
234+
// https://github.com/facebookincubator/create-react-app/issues/2627
235+
//
236+
// console.log(cyan('Running yarn...'));
237+
// spawnSync('yarnpkg', [], { stdio: 'inherit' });
225238
} else {
226239
console.log(cyan('Running npm install...'));
227240
spawnSync('npm', ['install'], { stdio: 'inherit' });

0 commit comments

Comments
 (0)