Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing the options.json file #589

Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix: missing the options.json file #589

merged 1 commit into from
Feb 20, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #588

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #589 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           8        8           
  Lines         228      228           
  Branches       71       71           
=======================================
  Hits          226      226           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d9460...cb535c1. Read the comment docs.

@alexander-akait
Copy link
Member Author

macOS sometimes freeze on azure 😕

@alexander-akait alexander-akait merged commit 41d6264 into master Feb 20, 2020
@alexander-akait alexander-akait deleted the issue-588 branch February 20, 2020 09:30
@ScriptedAlchemy
Copy link
Member

Haha, of course, :P its Microsoft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V4 rc: options.json not published to npm. Causes build failure
2 participants