Skip to content

Commit 09b923a

Browse files
authoredMay 19, 2021
style: avoid options for prettier (#915)
1 parent 1f7a65e commit 09b923a

38 files changed

+1460
-1461
lines changed
 

‎.eslintrc.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
module.exports = {
22
root: true,
3-
extends: ['@webpack-contrib/eslint-config-webpack', 'prettier'],
3+
extends: ["@webpack-contrib/eslint-config-webpack", "prettier"],
44
overrides: [
55
{
6-
files: ['src/**/*.js'],
6+
files: ["src/**/*.js"],
77
parserOptions: {
8-
sourceType: 'module',
8+
sourceType: "module",
99
},
1010
},
1111
],

‎.github/dependabot.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
version: 2
22
updates:
33
- package-ecosystem: npm
4-
directory: '/'
4+
directory: "/"
55
schedule:
66
interval: daily
7-
time: '04:00'
7+
time: "04:00"
88
timezone: Europe/Berlin
99
open-pull-requests-limit: 10
1010
versioning-strategy: lockfile-only

‎.prettierrc.js

-1
This file was deleted.

‎README.md

+39-39
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ _Note: We do not recommend installing this module globally._
3838
## Usage
3939

4040
```js
41-
const webpack = require('webpack');
42-
const middleware = require('webpack-dev-middleware');
41+
const webpack = require("webpack");
42+
const middleware = require("webpack-dev-middleware");
4343
const compiler = webpack({
4444
// webpack options
4545
});
46-
const express = require('express');
46+
const express = require("express");
4747
const app = express();
4848

4949
app.use(
@@ -52,7 +52,7 @@ app.use(
5252
})
5353
);
5454

55-
app.listen(3000, () => console.log('Example app listening on port 3000!'));
55+
app.listen(3000, () => console.log("Example app listening on port 3000!"));
5656
```
5757

5858
See [below](#other-servers) for an example of use with fastify.
@@ -82,7 +82,7 @@ or
8282
webpackDevMiddleware(compiler, {
8383
headers: () => {
8484
return {
85-
'Last-Modified': new Date(),
85+
"Last-Modified": new Date(),
8686
};
8787
},
8888
});
@@ -93,7 +93,7 @@ or
9393
```js
9494
webpackDevMiddleware(compiler, {
9595
headers: (req, res, context) => {
96-
res.setHeader('Last-Modified', new Date());
96+
res.setHeader("Last-Modified", new Date());
9797
},
9898
});
9999
```
@@ -152,7 +152,7 @@ This option also accepts a `Function` value, which can be used to filter which f
152152
The function follows the same premise as [`Array#filter`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter) in which a return value of `false` _will not_ write the file, and a return value of `true` _will_ write the file to disk. eg.
153153

154154
```js
155-
const webpack = require('webpack');
155+
const webpack = require("webpack");
156156
const configuration = {
157157
/* Webpack configuration */
158158
};
@@ -178,10 +178,10 @@ You have to provide `.join()` and `mkdirp` method to the `outputFileSystem` inst
178178
This can be done simply by using `path.join`:
179179

180180
```js
181-
const webpack = require('webpack');
182-
const path = require('path');
183-
const myOutputFileSystem = require('my-fs');
184-
const mkdirp = require('mkdirp');
181+
const webpack = require("webpack");
182+
const path = require("path");
183+
const myOutputFileSystem = require("my-fs");
184+
const mkdirp = require("mkdirp");
185185

186186
myOutputFileSystem.join = path.join.bind(path); // no need to bind
187187
myOutputFileSystem.mkdirp = mkdirp.bind(mkdirp); // no need to bind
@@ -212,12 +212,12 @@ Required: `No`
212212
A function executed once the middleware has stopped watching.
213213

214214
```js
215-
const express = require('express');
216-
const webpack = require('webpack');
215+
const express = require("express");
216+
const webpack = require("webpack");
217217
const compiler = webpack({
218218
/* Webpack configuration */
219219
});
220-
const middleware = require('webpack-dev-middleware');
220+
const middleware = require("webpack-dev-middleware");
221221
const instance = middleware(compiler);
222222

223223
const app = new express();
@@ -244,12 +244,12 @@ Required: `No`
244244
A function executed once the middleware has invalidated.
245245

246246
```js
247-
const express = require('express');
248-
const webpack = require('webpack');
247+
const express = require("express");
248+
const webpack = require("webpack");
249249
const compiler = webpack({
250250
/* Webpack configuration */
251251
});
252-
const middleware = require('webpack-dev-middleware');
252+
const middleware = require("webpack-dev-middleware");
253253
const instance = middleware(compiler);
254254

255255
const app = new express();
@@ -258,7 +258,7 @@ app.use(instance);
258258

259259
setTimeout(() => {
260260
// After a short delay the configuration is changed and a banner plugin is added to the config
261-
new webpack.BannerPlugin('A new banner').apply(compiler);
261+
new webpack.BannerPlugin("A new banner").apply(compiler);
262262

263263
// Recompile the bundle with the banner plugin:
264264
instance.invalidate();
@@ -281,20 +281,20 @@ A function executed when the bundle becomes valid.
281281
If the bundle is valid at the time of calling, the callback is executed immediately.
282282

283283
```js
284-
const express = require('express');
285-
const webpack = require('webpack');
284+
const express = require("express");
285+
const webpack = require("webpack");
286286
const compiler = webpack({
287287
/* Webpack configuration */
288288
});
289-
const middleware = require('webpack-dev-middleware');
289+
const middleware = require("webpack-dev-middleware");
290290
const instance = middleware(compiler);
291291

292292
const app = new express();
293293

294294
app.use(instance);
295295

296296
instance.waitUntilValid(() => {
297-
console.log('Package is in a valid state');
297+
console.log("Package is in a valid state");
298298
});
299299
```
300300

@@ -312,20 +312,20 @@ Required: `Yes`
312312
URL for the requested file.
313313

314314
```js
315-
const express = require('express');
316-
const webpack = require('webpack');
315+
const express = require("express");
316+
const webpack = require("webpack");
317317
const compiler = webpack({
318318
/* Webpack configuration */
319319
});
320-
const middleware = require('webpack-dev-middleware');
320+
const middleware = require("webpack-dev-middleware");
321321
const instance = middleware(compiler);
322322

323323
const app = new express();
324324

325325
app.use(instance);
326326

327327
instance.waitUntilValid(() => {
328-
const filename = instance.getFilenameFromUrl('/bundle.js');
328+
const filename = instance.getFilenameFromUrl("/bundle.js");
329329

330330
console.log(`Filename is ${filename}`);
331331
});
@@ -360,13 +360,13 @@ process is finished with server-side rendering enabled._
360360
Example Implementation:
361361

362362
```js
363-
const express = require('express');
364-
const webpack = require('webpack');
363+
const express = require("express");
364+
const webpack = require("webpack");
365365
const compiler = webpack({
366366
/* Webpack configuration */
367367
});
368-
const isObject = require('is-object');
369-
const middleware = require('webpack-dev-middleware');
368+
const isObject = require("is-object");
369+
const middleware = require("webpack-dev-middleware");
370370

371371
const app = new express();
372372

@@ -396,17 +396,17 @@ app.use((req, res) => {
396396
<title>My App</title>
397397
<style>
398398
${normalizeAssets(assetsByChunkName.main)
399-
.filter((path) => path.endsWith('.css'))
399+
.filter((path) => path.endsWith(".css"))
400400
.map((path) => outputFileSystem.readFileSync(path.join(outputPath, path)))
401-
.join('\n')}
401+
.join("\n")}
402402
</style>
403403
</head>
404404
<body>
405405
<div id="root"></div>
406406
${normalizeAssets(assetsByChunkName.main)
407-
.filter((path) => path.endsWith('.js'))
407+
.filter((path) => path.endsWith(".js"))
408408
.map((path) => `<script src="${path}"></script>`)
409-
.join('\n')}
409+
.join("\n")}
410410
</body>
411411
</html>
412412
`);
@@ -448,16 +448,16 @@ Examples of use with other servers will follow here.
448448
Fastify interop will require the use of `fastify-express` instead of `middie` for providing middleware support. As the authors of `fastify-express` recommend, this should only be used as a stopgap while full Fastify support is worked on.
449449

450450
```js
451-
const fastify = require('fastify')();
452-
const webpack = require('webpack');
453-
const webpackConfig = require('./webpack.config.js');
454-
const devMiddleware = require('webpack-dev-middleware');
451+
const fastify = require("fastify")();
452+
const webpack = require("webpack");
453+
const webpackConfig = require("./webpack.config.js");
454+
const devMiddleware = require("webpack-dev-middleware");
455455

456456
const compiler = webpack(webpackConfig);
457457
const { publicPath } = webpackConfig.output;
458458

459459
(async () => {
460-
await fastify.register(require('fastify-express'));
460+
await fastify.register(require("fastify-express"));
461461
await fastify.use(devMiddleware(compiler, { publicPath }));
462462
await fastify.listen(3000);
463463
})();

‎babel.config.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ module.exports = (api) => {
77
return {
88
presets: [
99
[
10-
'@babel/preset-env',
10+
"@babel/preset-env",
1111
{
1212
targets: {
13-
node: '10.13.0',
13+
node: "10.13.0",
1414
},
1515
},
1616
],

‎commitlint.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module.exports = {
2-
extends: ['@commitlint/config-conventional'],
2+
extends: ["@commitlint/config-conventional"],
33
};

‎jest.config.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
module.exports = {
2-
testEnvironment: 'node',
2+
testEnvironment: "node",
33
collectCoverage: false,
4-
coveragePathIgnorePatterns: ['test', '<rootDir>/node_modules'],
5-
moduleFileExtensions: ['js', 'json'],
6-
testMatch: ['**/test/**/*.test.js'],
7-
setupFilesAfterEnv: ['<rootDir>/setupTest.js'],
8-
globalSetup: '<rootDir>/scripts/globalSetup.js',
9-
snapshotResolver: './test/helpers/snapshotResolver.js',
4+
coveragePathIgnorePatterns: ["test", "<rootDir>/node_modules"],
5+
moduleFileExtensions: ["js", "json"],
6+
testMatch: ["**/test/**/*.test.js"],
7+
setupFilesAfterEnv: ["<rootDir>/setupTest.js"],
8+
globalSetup: "<rootDir>/scripts/globalSetup.js",
9+
snapshotResolver: "./test/helpers/snapshotResolver.js",
1010
};

‎lint-staged.config.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
module.exports = {
2-
'*.js': ['prettier --write', 'eslint --fix'],
3-
'*.{json,md,yml,css}': ['prettier --write'],
2+
"*.js": ["prettier --write", "eslint --fix"],
3+
"*.{json,md,yml,css}": ["prettier --write"],
44
};

‎scripts/globalSetup.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const { version } = require('webpack');
1+
const { version } = require("webpack");
22

33
module.exports = () =>
44
console.log(`\n Running tests for webpack @${version} \n`);

‎setupTest.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
'use strict';
1+
"use strict";
22

33
jest.setTimeout(20000);

‎src/cjs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
const middleware = require('./index');
1+
const middleware = require("./index");
22

33
module.exports = middleware.default;

‎src/index.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
import { validate } from 'schema-utils';
2-
import mime from 'mime-types';
1+
import { validate } from "schema-utils";
2+
import mime from "mime-types";
33

4-
import middleware from './middleware';
5-
import getFilenameFromUrl from './utils/getFilenameFromUrl';
6-
import setupHooks from './utils/setupHooks';
7-
import setupWriteToDisk from './utils/setupWriteToDisk';
8-
import setupOutputFileSystem from './utils/setupOutputFileSystem';
9-
import ready from './utils/ready';
10-
import schema from './options.json';
4+
import middleware from "./middleware";
5+
import getFilenameFromUrl from "./utils/getFilenameFromUrl";
6+
import setupHooks from "./utils/setupHooks";
7+
import setupWriteToDisk from "./utils/setupWriteToDisk";
8+
import setupOutputFileSystem from "./utils/setupOutputFileSystem";
9+
import ready from "./utils/ready";
10+
import schema from "./options.json";
1111

1212
const noop = () => {};
1313

1414
export default function wdm(compiler, options = {}) {
1515
validate(schema, options, {
16-
name: 'Dev Middleware',
17-
baseDataPath: 'options',
16+
name: "Dev Middleware",
17+
baseDataPath: "options",
1818
});
1919

2020
const { mimeTypes } = options;
@@ -38,7 +38,7 @@ export default function wdm(compiler, options = {}) {
3838

3939
// eslint-disable-next-line no-param-reassign
4040
context.logger = context.compiler.getInfrastructureLogger(
41-
'webpack-dev-middleware'
41+
"webpack-dev-middleware"
4242
);
4343

4444
setupHooks(context);

0 commit comments

Comments
 (0)