-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 of css-module has broken ability to use mini-css-extract-plugin with css modules. #556
Comments
It was written in the original issue webpack-contrib/css-loader#1029, |
Apologies, I didn't see that. Might I suggest unmarking v4.0.0 as I lost a good couple hours last night between |
@tswaters sometimes using search is not bad idea 😄 |
Came to find/file a similar issue. Seems like this issue should be reopened because mini-extract needs work to support this and webpack-contrib/css-loader#1029 can be closed because that end was completed. Thanks for the work on this! |
@gpoitch we keep this issue in |
Expected Behavior
Continue to get named exports.
Actual Behavior
No named exports!
Code
After uncommenting
MiniCssExtractPlugin.loader
andnew MiniCssExtractPlugin()
in plugins section, the export no longer comes forward. The object returned from that entire module is{}
and so the class names aren't coming through.How Do We Reproduce?
You can clone this repo :
https://github.com/tswaters/css-loader-4-0-0-mini-extract-issue
The readme should be pretty self-explanatory -- but
npm start
and you'll see the index.js file console.logs undefined.git checkout .
,git checkout old-version-of-css-loader
, andnpm ci
-- npm start will now output the class name properly, and the css is outputI'm not sure if If I'm missing some kind of configuration option with css-loader or if it's a bug with mini-css-extract-plugin or some combination of configuration between these two modules that is breaking things....
I had a heck of a time just getting the exports to work properly again under v4.0.0 -- but can't seem to get mini-css-extract-plugin to not interfere with the names exports showing up in generated bundle.
The text was updated successfully, but these errors were encountered: