Skip to content

Commit 30ef035

Browse files
chore(deps): update pre-commit hooks (scikit-build#1123)
<!--pre-commit.ci start--> updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.2 → v0.12.7](astral-sh/ruff-pre-commit@v0.12.2...v0.12.7) - [github.com/pre-commit/mirrors-mypy: v1.16.1 → v1.17.1](pre-commit/mirrors-mypy@v1.16.1...v1.17.1) - [github.com/henryiii/validate-pyproject-schema-store: 2025.06.23 → 2025.07.28](henryiii/validate-pyproject-schema-store@2025.06.23...2025.07.28) <!--pre-commit.ci end--> --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
1 parent 6084109 commit 30ef035

File tree

4 files changed

+18
-10
lines changed

4 files changed

+18
-10
lines changed

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ repos:
2525
exclude: "^tests"
2626

2727
- repo: https://github.com/astral-sh/ruff-pre-commit
28-
rev: v0.12.2
28+
rev: v0.12.7
2929
hooks:
3030
- id: ruff
3131
args: ["--fix", "--show-fixes"]
@@ -59,7 +59,7 @@ repos:
5959
exclude: "^tests|src/scikit_build_core/resources/scikit-build.schema.json|^docs/projects.md"
6060

6161
- repo: https://github.com/pre-commit/mirrors-mypy
62-
rev: v1.16.1
62+
rev: v1.17.1
6363
hooks:
6464
- id: mypy
6565
exclude: |
@@ -131,7 +131,7 @@ repos:
131131
additional_dependencies: ["cogapp>=3.5"]
132132

133133
- repo: https://github.com/henryiii/validate-pyproject-schema-store
134-
rev: 2025.06.23
134+
rev: 2025.07.28
135135
hooks:
136136
- id: validate-pyproject
137137

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ exclude = [
178178
'^tests/packages/extensionlib/*',
179179
]
180180
mypy_path = ["$MYPY_CONFIG_FILE_DIR/src", "$MYPY_CONFIG_FILE_DIR/tests/utils"]
181-
python_version = "3.8"
181+
python_version = "3.9"
182182
warn_unused_configs = true
183183
warn_unreachable = false
184184
enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]

src/scikit_build_core/builder/builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import sys
88
import sysconfig
99
from pathlib import Path
10-
from typing import TYPE_CHECKING
10+
from typing import TYPE_CHECKING, Any
1111

1212
from .. import __version__
1313
from .._compat.importlib import metadata, resources
@@ -85,7 +85,7 @@ def _filter_env_cmake_args(env_cmake_args: list[str]) -> Generator[str, None, No
8585
yield arg
8686

8787

88-
def _sanitize_path(path: os.PathLike[str]) -> list[Path]:
88+
def _sanitize_path(path: Any) -> list[Path]:
8989
# This handles classes like:
9090
# MultiplexedPath from importlib.resources.readers (3.11+)
9191
# MultiplexedPath from importlib.readers (3.10)

tests/test_editable.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
from __future__ import annotations
2+
13
import platform
24
import sys
35
import textwrap
46
from pathlib import Path
57

68
import pytest
7-
from conftest import PackageInfo, process_package
9+
from conftest import PackageInfo, VEnv, process_package
810

911

1012
@pytest.mark.compile
@@ -160,8 +162,12 @@ def test_install_dir(isolated):
160162

161163

162164
def _setup_package_for_editable_layout_tests(
163-
monkeypatch, tmp_path, editable, editable_mode, isolated
164-
):
165+
monkeypatch: pytest.MonkeyPatch,
166+
tmp_path: Path,
167+
editable: bool,
168+
editable_mode: str,
169+
isolated: VEnv,
170+
) -> None:
165171
editable_flag = ["-e"] if editable else []
166172

167173
config_mode_flags = []
@@ -177,6 +183,8 @@ def _setup_package_for_editable_layout_tests(
177183
package = PackageInfo("importlib_editable")
178184
process_package(package, tmp_path, m)
179185

186+
assert isolated.wheelhouse
187+
180188
ninja = [
181189
"ninja"
182190
for f in isolated.wheelhouse.iterdir()
@@ -211,7 +219,7 @@ def test_direct_import(monkeypatch, tmp_path, editable, editable_mode, isolated)
211219
if platform.system() == "Windows" and editable_mode == "inplace":
212220
pytest.xfail("Windows fails to import the top-level extension module")
213221

214-
_setup_package_for_editable_layout_tests( # type: ignore[no-untyped-call]
222+
_setup_package_for_editable_layout_tests(
215223
monkeypatch, tmp_path, editable, editable_mode, isolated
216224
)
217225
isolated.execute("import pkg")

0 commit comments

Comments
 (0)