Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline fix and various tslint rule changes #24

Merged
merged 2 commits into from
Sep 22, 2015
Merged

Newline fix and various tslint rule changes #24

merged 2 commits into from
Sep 22, 2015

Conversation

myitcv
Copy link
Contributor

@myitcv myitcv commented Sep 22, 2015

@vvakame - I've closed #19 and rebased my changes against your recent commits. Would appreciate some feedback on these changes:

  • Use process.(stderr|stdout) to fix this issue
  • Fix references to and use of the tslint indent rule (and corresponding config). The rule takes a [boolean, string] pair, like this. There was an error in the tslint docs which has now been fixed
  • Introduce AdditionalFormatOptions to reference tslint "no-consecutive-blank-lines" and "no-trailing-whitespace" config options. These are not supported by the core ts.FormatCodeOptions. Perform simple regex replaces if these options are set

@vvakame vvakame merged commit bb05b98 into vvakame:master Sep 22, 2015
vvakame added a commit that referenced this pull request Sep 22, 2015
Merge branch 'myitcv-newline_and_indent_fixes'
@vvakame
Copy link
Owner

vvakame commented Sep 22, 2015

it merged. thanks!

@myitcv
Copy link
Contributor Author

myitcv commented Sep 22, 2015

@vvakame - thanks

@myitcv
Copy link
Contributor Author

myitcv commented Sep 22, 2015

@vvakame - just to check, your various refactors removed the change for stripping of trailing whitespace. Was this intentional? I find this to be extremely useful, particularly for the code generated typescript we are working with.

@vvakame
Copy link
Owner

vvakame commented Sep 23, 2015

I think remove trailing spaces are default of typescript service.
I added the test code.
do i have a any mistakes?

@myitcv
Copy link
Contributor Author

myitcv commented Sep 23, 2015

@vvakame - apologies, my bad. Yes, the TS service does remove trailing whitespaces, but not it seems from "blank" lines (i.e. lines that only contain whitespace) within comments. Whereas my previous regex replace of course just blanket applies a string replace. No changes needed here then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Verification method to assure that code is formatted properly
2 participants