Skip to content

Commit 6d04913

Browse files
committed
feat(tsfmt): don't use default export in our code
1 parent 1520cf8 commit 6d04913

7 files changed

+20
-20
lines changed

lib/formatter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class LanguageServiceHost implements ts.LanguageServiceHost {
1818
getDefaultLibFileName = (_options: ts.CompilerOptions) => "lib";
1919
}
2020

21-
export default function format(fileName: string, text: string, options = createDefaultFormatCodeSettings()) {
21+
export function format(fileName: string, text: string, options = createDefaultFormatCodeSettings()) {
2222
const host = new LanguageServiceHost();
2323
host.addFile(fileName, text);
2424

lib/index.ts

+14-14
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import * as ts from "typescript";
2-
import formatter from "./formatter";
2+
import { format } from "./formatter";
33
import { createDefaultFormatCodeSettings, parseJSON } from "./utils";
44

55
export { parseJSON };
66

77
import * as fs from "fs";
88
import * as path from "path";
99

10-
import base from "./provider/base";
11-
import tsconfigjson from "./provider/tsconfigjson";
12-
import editorconfig, { postProcess as editorconfigPostProcess } from "./provider/editorconfig";
13-
import tslintjson, { postProcess as tslintPostProcess } from "./provider/tslintjson";
14-
import vscodesettings from "./provider/vscodesettings";
10+
import * as base from "./provider/base";
11+
import * as tsconfigjson from "./provider/tsconfigjson";
12+
import * as editorconfig from "./provider/editorconfig";
13+
import * as tslintjson from "./provider/tslintjson";
14+
import * as vscodesettings from "./provider/vscodesettings";
1515

1616
const packageJson = JSON.parse(fs.readFileSync(path.join(__dirname, "../package.json")).toString());
1717
export const version = packageJson.version;
@@ -144,21 +144,21 @@ export function processString(fileName: string, content: string, opts: Options):
144144

145145
let processor = new Processor();
146146
if (opts.tsfmt) {
147-
processor.addOptionModify(base);
147+
processor.addOptionModify(base.makeFormatCodeOptions);
148148
}
149149
if (opts.tsconfig) {
150-
processor.addOptionModify(tsconfigjson);
150+
processor.addOptionModify(tsconfigjson.makeFormatCodeOptions);
151151
}
152152
if (opts.editorconfig) {
153-
processor.addOptionModify(editorconfig);
154-
processor.addPostProcess(editorconfigPostProcess);
153+
processor.addOptionModify(editorconfig.makeFormatCodeOptions);
154+
processor.addPostProcess(editorconfig.postProcess);
155155
}
156156
if (opts.tslint) {
157-
processor.addOptionModify(tslintjson);
158-
processor.addPostProcess(tslintPostProcess);
157+
processor.addOptionModify(tslintjson.makeFormatCodeOptions);
158+
processor.addPostProcess(tslintjson.postProcess);
159159
}
160160
if (opts.vscode) {
161-
processor.addOptionModify(vscodesettings);
161+
processor.addOptionModify(vscodesettings.makeFormatCodeOptions);
162162
}
163163
processor.addPostProcess((_fileName: string, formattedCode: string, _opts: Options, formatSettings: ts.FormatCodeSettings) => {
164164
// replace newline code. maybe NewLineCharacter params affect to only "new" newline by language service.
@@ -169,7 +169,7 @@ export function processString(fileName: string, content: string, opts: Options):
169169
let formatSettings = createDefaultFormatCodeSettings();
170170
return processor.processFormatCodeOptions(fileName, opts, formatSettings)
171171
.then(formatSettings => {
172-
let formattedCode = formatter(fileName, content, formatSettings);
172+
let formattedCode = format(fileName, content, formatSettings);
173173

174174
// apply post process logic
175175
return processor.postProcess(fileName, formattedCode, opts, formatSettings);

lib/provider/base.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface TsfmtSettings {
3131
convertTabsToSpaces?: boolean;
3232
}
3333

34-
export default function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
34+
export function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
3535
let baseDir = opts.baseDir ? path.resolve(opts.baseDir) : path.dirname(path.resolve(fileName));
3636
let configFileName: string | null;
3737
if (opts.tsfmtFile && path.isAbsolute(opts.tsfmtFile)) {

lib/provider/editorconfig.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { Options } from "../";
66

77
let emitBaseDirWarning = false;
88

9-
export default function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): Promise<ts.FormatCodeSettings> {
9+
export function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): Promise<ts.FormatCodeSettings> {
1010

1111
if (opts.verbose && opts.baseDir && !emitBaseDirWarning) {
1212
console.log("editorconfig is not supported baseDir options");

lib/provider/tsconfigjson.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as path from "path";
55
import { Options } from "../";
66
import { getConfigFileName, readTsconfig } from "../utils";
77

8-
export default function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
8+
export function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
99

1010
let baseDir = opts.baseDir ? path.resolve(opts.baseDir) : path.dirname(path.resolve(fileName));
1111
let configFileName: string | null;

lib/provider/tslintjson.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export interface AdditionalFormatSettings {
2929
$noConsecutiveBlankLines: boolean;
3030
}
3131

32-
export default function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
32+
export function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
3333

3434
let baseDir = opts.baseDir ? path.resolve(opts.baseDir) : path.dirname(path.resolve(fileName));
3535
let configFileName: string | null;

lib/provider/vscodesettings.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ interface VSCodeSettings {
2727
// insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces, insertSpaceAfterTypeAssertion, insertSpaceBeforeFunctionParenthesis
2828
}
2929

30-
export default function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
30+
export function makeFormatCodeOptions(fileName: string, opts: Options, formatSettings: ts.FormatCodeSettings): ts.FormatCodeSettings {
3131

3232
let baseDir = opts.baseDir ? path.resolve(opts.baseDir) : path.dirname(path.resolve(fileName));
3333
let configFileName = getConfigFileName(baseDir, "./.vscode/settings.json");

0 commit comments

Comments
 (0)