feat(generator): allow plugins to modify how configs are extracted #1130
+288
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Apr 26, 2018
| * config object, whether to check for an existing config on disk, and the | ||
| * current context. | ||
| */ | ||
| addConfigTransform (key, configTransform) { |
There was a problem hiding this comment.
I think the current API would be a bit difficult to use as the plugin author would have to reimplement makeXXXTransform or require vue-cli internals (risks breaking).
The second argument could also accept an object in the form of
{
file: '.baberc.js',
type: 'js|json|multi'
}
In this case we can create a transform function based on this information.
added 6 commits
April 27, 2018 14:17
Allow plugin author to set config 'descriptions' instead of implementing their own transform functions.
pksunkara
approved these changes
Jul 5, 2018
|
This PR looks good. @yyx990803 Any update on this? The author has addressed your review comments. |
|
I have merged dev and refactored config transforms to a more flexible system similar to the one used by the ui. (Will eventually merge the two systems.) |
pksunkara
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help plugin developers that are working on plugins for libraries/framerworks/etc that can be configured in multiple places (a field in package.json, multiple files). Or users that want to create a personal plugin that they can add to a preset to quickly setup a project in the case that they would prefer a different configuration file type over the defaults (eg.
.babelrc.jsover.babelrc).Related: #994
Closes: #1076