Skip to content

Commit b799b83

Browse files
authored
fix(upgrade): correctly update version range in package.json (#4546)
1 parent 4aba6e1 commit b799b83

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

packages/@vue/cli/__tests__/Upgrader.spec.js

+3
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ test('upgrade: plugin-babel v3.5', async () => {
3434
expect(updatedPkg.dependencies).toHaveProperty('core-js')
3535

3636
expect(logs.log.some(([msg]) => msg.match('core-js has been upgraded'))).toBe(true)
37+
38+
// should have updated the version range in package.json
39+
expect(updatedPkg.devDependencies['@vue/cli-plugin-babel']).not.toMatch('3.5.3')
3740
})
3841

3942
test('upgrade: plugin-babel with core-js 2', async () => {

packages/@vue/cli/lib/Upgrader.js

+2
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ module.exports = class Upgrader {
101101
log(`Upgrading ${packageName} from ${installed} to ${targetVersion}`)
102102
await this.pm.upgrade(`${packageName}@^${targetVersion}`)
103103

104+
// the cached `pkg` field won't automatically update after running `this.pm.upgrade`
105+
this.pkg[depEntry][packageName] = `^${targetVersion}`
104106
await this.runMigrator(packageName, { installed })
105107
}
106108

0 commit comments

Comments
 (0)