fix(router): pass the base option as an argument (#15)

* fix(router): pass the base option as an argument

Close #14

* test: remove redundant cases

Author: posva

generator/codemods/router/__testfixtures__/create-history.input.js

@@ -20,4 +20,9 @@ const router = new VueRouter({
   routes
 });
 
+new VueRouter({
+  mode: 'history',
+  routes
+});
+
 export default router;

generator/codemods/router/__testfixtures__/create-history.output.js

@@ -15,8 +15,12 @@ const routes = [
 ];
 
 const router = createRouter({
+  history: createWebHistory(process.env.BASE_URL),
+  routes
+});
+
+createRouter({
   history: createWebHistory(),
-  base: process.env.BASE_URL,
   routes
 });
 

generator/codemods/router/__testfixtures__/create-router.input.js

@@ -19,4 +19,8 @@ const router = new VueRouter({
   routes
 });
 
+new VueRouter({
+  routes
+});
+
 export default router;

generator/codemods/router/__testfixtures__/create-router.output.js

@@ -1,4 +1,4 @@
-import { createRouter } from 'vue-router';
+import { createRouter, createWebHashHistory } from 'vue-router';
 import Home from '../views/Home.vue';
 
 const routes = [
@@ -15,7 +15,12 @@ const routes = [
 ];
 
 const router = createRouter({
-  base: process.env.BASE_URL,
+  history: createWebHashHistory(process.env.BASE_URL),
+  routes
+});
+
+createRouter({
+  history: createWebHashHistory(),
   routes
 });
 

generator/codemods/router/index.js

@@ -28,33 +28,47 @@ module.exports = function(fileInfo, api) {
     addImport(context, { imported: 'createRouter' }, 'vue-router')
     newVueRouter.replaceWith(({ node }) => {
       // mode: 'history' -> history: createWebHistory(), etc
+      let historyMode = 'createWebHashHistory'
+      let baseValue
       node.arguments[0].properties = node.arguments[0].properties.map(p => {
         if (p.key.name === 'mode') {
           const mode = p.value.value
-          let initializer
           if (mode === 'hash') {
-            initializer = 'createWebHashHistory'
+            historyMode = 'createWebHashHistory'
           } else if (mode === 'history') {
-            initializer = 'createWebHistory'
+            historyMode = 'createWebHistory'
           } else if (mode === 'abstract') {
-            initializer = 'createMemoryHistory'
+            historyMode = 'createMemoryHistory'
           } else {
             console.error(
               `mode must be one of 'hash', 'history', or 'abstract'`
             )
             return p
           }
-
-          addImport(context, { imported: initializer }, 'vue-router')
-          return j.objectProperty(
-            j.identifier('history'),
-            j.callExpression(j.identifier(initializer), [])
-          )
+          return
+        } else if (p.key.name === 'base') {
+          baseValue = p.value
+          return
         }
 
         return p
       })
 
+      // add the default mode with a hash history
+      addImport(context, { imported: historyMode }, 'vue-router')
+      node.arguments[0].properties = node.arguments[0].properties.filter(
+        p => !!p
+      )
+      node.arguments[0].properties.unshift(
+        j.objectProperty(
+          j.identifier('history'),
+          j.callExpression(
+            j.identifier(historyMode),
+            baseValue ? [baseValue] : []
+          )
+        )
+      )
+
       return j.callExpression(j.identifier('createRouter'), node.arguments)
     })
     removeExtraneousImport(context, localVueRouter)