fix: fix remove-extraneous-import implementation

Author: haoqunjiang

generator/codemods/global-api/__testfixtures__/vue-use.output.js

@@ -0,0 +1,3 @@
+import 'vue';
+import 'vue-router';
+import 'Vuex';

generator/codemods/utils/remove-extraneous-import.js

@@ -1,22 +1,62 @@
 /**
+ * Note:
+ * here we don't completely remove the import declaration statement
+ * if all import specifiers are removed.
+ * For example, `import Vue from 'vue'`,
+ * if `Vue` is unused, the statement would become `import 'vue'`.
+ * It is because we are not sure if the module contains any side effects.
  * @param {Object} context
  * @param {import('jscodeshift').JSCodeshift} context.j
  * @param {ReturnType<import('jscodeshift').Core>} context.root
  */
-function removeExtraneousImport({ root, j }, name) {
-  const localUsages = root.find(j.Identifier, { name })
-  if (localUsages.length === 1) {
-    const importDecl = localUsages.closest(j.ImportDeclaration)
-    
-    if (!importDecl.length) {
-      return
-    }
+module.exports = function removeExtraneousImport({ root, j }, name) {
+  const isPathEqual = (path1, path2) => {
+    return (
+      path1.node.start === path2.node.start && path1.node.end === path2.node.end
+    )
+  }
+  /**
+   * @param {import('jscodeshift').ASTPath} path
+   */
+  function filterAndRemoveImports(path) {
+    const usages = j(path)
+      .closestScope()
+      .find(j.Identifier, { name })
+      // Ignore the specifier
+      .filter(identifierPath => {
+        const parent = identifierPath.parent.node
+        return (
+          !j.ImportDefaultSpecifier.check(parent) &&
+          !j.ImportSpecifier.check(parent)
+        )
+      })
+      // Ignore properties in MemberExpressions
+      .filter(identifierPath => {
+        const parent = identifierPath.parent.node
+        return !(
+          j.MemberExpression.check(parent) &&
+          parent.property === identifierPath.node
+        )
+      })
 
-    if (importDecl.get(0).node.specifiers.length === 1) {
-      importDecl.remove()
-    } else {
-      localUsages.closest(j.ImportSpecifier).remove()
-      localUsages.closest(j.ImportDefaultSpecifier).remove()
+    if (!usages.length) {
+      j(path).remove()
     }
   }
+
+  root
+    .find(j.ImportSpecifier, {
+      local: {
+        name
+      }
+    })
+    .filter(filterAndRemoveImports)
+
+  root
+    .find(j.ImportDefaultSpecifier, {
+      local: {
+        name
+      }
+    })
+    .filter(filterAndRemoveImports)
 }