Fix one sonarcloud bug & update check-header trigger rule (#434)

rekeyz · web-flow · commit 87c7410f8875 · 2024-02-07T13:38:23.000+08:00
* fix 1 sonarcloud bug

* update check-header trigger rule
diff --git a/.github/workflows/check-header.yml b/.github/workflows/check-header.yml
@@ -1,13 +1,13 @@
 #
-# Copyright 2019-2021 VMware, Inc.
+# Copyright 2019-2024 VMware, Inc.
 # SPDX-License-Identifier: Apache-2.0
 #
 
 name: check-header
 
 on:
   push:
-    branches: ["**", '!master']
+    branches: ["**"]
   pull_request:
     branches: ['**']
 
diff --git a/.github/workflows/sonarcloud_scan_app.yml b/.github/workflows/sonarcloud_scan_app.yml
@@ -1,13 +1,13 @@
 #
-# Copyright 2019-2021 VMware, Inc.
+# Copyright 2019-2024 VMware, Inc.
 # SPDX-License-Identifier: Apache-2.0
 #
 
 name: sonarcloud_scan_app
 
 on:
   push:
-    branches: ["**", '!master']
+    branches: ["**"]
   pull_request:
     branches: ['**']
 
diff --git a/annotation-app/src/app/component/projects/project-analyze/project-analyze.component.ts b/annotation-app/src/app/component/projects/project-analyze/project-analyze.component.ts
@@ -1753,7 +1753,7 @@ export class ProjectAnalyzeComponent implements OnInit {
     let flag1;
     let flag2;
     if (this.projectType == 'ner' || this.projectType == 'qa' || this.projectType == 'log') {
-      flag1 = this.sr.userInputs && this.sr.userInputs.length > 0 && this.sr.userInputs[0].problemCategory.length >= 0;
+      flag1 = this.sr.userInputs && this.sr.userInputs.length > 0 && this.sr.userInputs[0].problemCategory.length;
     } else {
       flag1 = this.sr.userInputs && this.sr.userInputs.length > 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,13 @@`
`1`	`1`	`#`
`2`		`-# Copyright 2019-2021 VMware, Inc.`
	`2`	`+# Copyright 2019-2024 VMware, Inc.`
`3`	`3`	`# SPDX-License-Identifier: Apache-2.0`
`4`	`4`	`#`
`5`	`5`
`6`	`6`	`name: check-header`
`7`	`7`
`8`	`8`	`on:`
`9`	`9`	`push:`
`10`		`- branches: ["**", '!master']`
	`10`	`+ branches: ["**"]`
`11`	`11`	`pull_request:`
`12`	`12`	`branches: ['**']`
`13`	`13`
Original file line number	Diff line number	Diff line change
`@@ -1753,7 +1753,7 @@ export class ProjectAnalyzeComponent implements OnInit {`
`1753`	`1753`	`let flag1;`
`1754`	`1754`	`let flag2;`
`1755`	`1755`	`if (this.projectType == 'ner' \|\| this.projectType == 'qa' \|\| this.projectType == 'log') {`
`1756`		`- flag1 = this.sr.userInputs && this.sr.userInputs.length > 0 && this.sr.userInputs[0].problemCategory.length >= 0;`
	`1756`	`+ flag1 = this.sr.userInputs && this.sr.userInputs.length > 0 && this.sr.userInputs[0].problemCategory.length;`
`1757`	`1757`	`} else {`
`1758`	`1758`	`flag1 = this.sr.userInputs && this.sr.userInputs.length > 0;`
`1759`	`1759`	`}`