Skip to content

Commit db9e687

Browse files
authored
Default state to {} (lyft#5)
1 parent 0169d0d commit db9e687

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

Diff for: src/helpers/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export function isReactComponent(classDeclaration: ts.ClassDeclaration, typeChec
4646
/**
4747
* Determine if a ts.HeritageClause is React HeritageClause
4848
*
49-
* @example `extends React.Component<{}, void>` is a React HeritageClause
49+
* @example `extends React.Component<{}, {}>` is a React HeritageClause
5050
*
5151
* @todo: this is lazy. Use the typeChecker instead
5252
* @param clause

Diff for: src/transforms/react-js-make-props-and-state-transform.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export function reactJSMakePropsAndStateInterfaceTransformFactoryFactory(typeChe
106106
const initialStateIsVoid = initialState.kind === ts.SyntaxKind.VoidKeyword;
107107
const collectedStateTypes = getStateLookingForSetStateCalls(classDeclaration, typeChecker);
108108
if (!collectedStateTypes.length && initialStateIsVoid) {
109-
return initialState;
109+
return ts.createTypeLiteralNode([]);
110110
}
111111
if (!initialStateIsVoid) {
112112
collectedStateTypes.push(initialState)

Diff for: test/end-to-end/basic/output.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
22

33
type MyComponentProps = {};
4-
type MyComponentState = void;
4+
type MyComponentState = {};
55

66
export default class MyComponent extends React.Component<MyComponentProps, MyComponentState> {
77
render() {

Diff for: test/react-hoist-generics-transform/propless-stateless/input.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22

3-
export default class MyComponent extends React.Component<{}, void> {
3+
export default class MyComponent extends React.Component<{}, {}> {
44
render() {
55
return <div />;
66
}

Diff for: test/react-hoist-generics-transform/propless-stateless/output.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
22

33
type MyComponentProps = {};
4-
type MyComponentState = void;
4+
type MyComponentState = {};
55
export default class MyComponent extends React.Component<MyComponentProps, MyComponentState> {
66
render() {
77
return <div />;

Diff for: test/react-js-make-props-and-state-transform/propless-stateless/output.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22

3-
export default class MyComponent extends React.Component<{}, void> {
3+
export default class MyComponent extends React.Component<{}, {}> {
44
render() {
55
return <div />;
66
}

Diff for: test/react-js-make-props-and-state-transform/static-proptypes-getter-simple/output.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as React from 'react';
22

33
export default class MyComponent extends React.Component<{
44
foo: string;
5-
}, void> {
5+
}, {}> {
66
static get propTypes() {
77
return {
88
foo: React.PropTypes.string.isRequired,

Diff for: test/react-js-make-props-and-state-transform/static-proptypes-many-props/output.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default class MyComponent extends React.Component<{
1919
stringRequired: string;
2020
nodeRequired: number | string | JSX.Element;
2121
elementRequired: JSX.Element;
22-
}, void> {
22+
}, {}> {
2323
static propTypes = {
2424
any: React.PropTypes.any,
2525
array: React.PropTypes.array,

Diff for: test/react-js-make-props-and-state-transform/static-proptypes-simple/output.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as React from 'react';
22

33
export default class MyComponent extends React.Component<{
44
foo: string;
5-
}, void> {
5+
}, {}> {
66
static propTypes = {
77
foo: React.PropTypes.string.isRequired,
88
};

0 commit comments

Comments
 (0)