From 7c2bd0e7270b83e4fa453e7e375ee96dfd60061d Mon Sep 17 00:00:00 2001 From: Benjamin Blumer Date: Fri, 10 Jun 2022 00:33:18 -0700 Subject: [PATCH] Fix 404 error for viewsets using get_queryset. (#15) [Django Rest Framework allows users to set the queryset by overriding the get_queryset method.](https://www.django-rest-framework.org/api-guide/filtering/) However, just reading the queryset attribute bypasses that. As a result, users will get 404 errors if they've overridden the get_queryset method instead of setting the class variable queryset. --- rest_framework_datatables_editor/viewsets.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rest_framework_datatables_editor/viewsets.py b/rest_framework_datatables_editor/viewsets.py index b1cc5db..0942e50 100644 --- a/rest_framework_datatables_editor/viewsets.py +++ b/rest_framework_datatables_editor/viewsets.py @@ -66,7 +66,7 @@ def editor(self, request): return_data.append(serializer.data) continue - elem = get_object_or_404(self.queryset, pk=elem_id) + elem = get_object_or_404(self.get_queryset(), pk=elem_id) if act == 'edit': check_fields(self.serializer_class, data) serializer = self.serializer_class(