fixed bug #362, also set chunks names (#363)

mr47 · arunoda · commit 45e36fdff73e · 2016-12-16T03:59:59.000+05:30
* fixed bug #362, also set chunks names * set simple solution for minChunks * revert in favor of #310
diff --git a/server/build/webpack.js b/server/build/webpack.js
@@ -45,7 +45,7 @@ export default async function createCompiler (dir, { hotReload = false, dev = fa
     new webpack.optimize.CommonsChunkPlugin({
       name: 'commons',
       filename: 'commons.js',
-      minChunks: pages.length
+      minChunks: Math.max(2, pages.length)
     })
   ]
 
diff --git a/server/index.js b/server/index.js
@@ -54,7 +54,6 @@ export default class Server {
       const p = join(__dirname, '..', 'client', ...(params.path || []))
       await this.serveStatic(req, res, p)
     })
-
     this.router.get('/static/:path+', async (req, res, params) => {
       const p = join(this.dir, 'static', ...(params.path || []))
       await this.serveStatic(req, res, p)

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export default async function createCompiler (dir, { hotReload = false, dev = fa`
`45`	`45`	`new webpack.optimize.CommonsChunkPlugin({`
`46`	`46`	`name: 'commons',`
`47`	`47`	`filename: 'commons.js',`
`48`		`- minChunks: pages.length`
	`48`	`+ minChunks: Math.max(2, pages.length)`
`49`	`49`	`})`
`50`	`50`	`]`
`51`	`51`