Merge pull request loiane#50 from christianbender/improved_balanced_symbols

loiane · web-flow · commit f06c85c1382a · 2018-04-24T21:05:53.000-04:00
improved the algorithm
diff --git a/src/js/others/balanced-symbols.js b/src/js/others/balanced-symbols.js
@@ -11,7 +11,7 @@ export function parenthesesChecker(symbols) {
   let top;
 
   while (index < symbols.length && balanced) {
-    symbol = symbols.charAt(index);
+    symbol = symbols[index];
     if (opens.indexOf(symbol) >= 0) {
       stack.push(symbol);
     } else if (stack.isEmpty()) {
@@ -24,8 +24,5 @@ export function parenthesesChecker(symbols) {
     }
     index++;
   }
-  if (balanced && stack.isEmpty()) {
-    return true;
-  }
-  return false;
+  return balanced && stack.isEmpty();
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export function parenthesesChecker(symbols) {`
`11`	`11`	`let top;`
`12`	`12`
`13`	`13`	`while (index < symbols.length && balanced) {`
`14`		`- symbol = symbols.charAt(index);`
	`14`	`+ symbol = symbols[index];`
`15`	`15`	`if (opens.indexOf(symbol) >= 0) {`
`16`	`16`	`stack.push(symbol);`
`17`	`17`	`} else if (stack.isEmpty()) {`
`@@ -24,8 +24,5 @@ export function parenthesesChecker(symbols) {`
`24`	`24`	`}`
`25`	`25`	`index++;`
`26`	`26`	`}`
`27`		`- if (balanced && stack.isEmpty()) {`
`28`		`- return true;`
`29`		`- }`
`30`		`- return false;`
	`27`	`+ return balanced && stack.isEmpty();`
`31`	`28`	`}`