Skip to content

Commit 337557c

Browse files
committed
Merge branch 'main' into nightly
2 parents d2c2cc1 + 5b5e034 commit 337557c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

unsloth/models/rl.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,9 @@ def _patch_trl_rl_trainers(trainer_file = "grpo_trainer"):
537537
"loss_type" : "bnpo", # Default GRPO paper
538538
"beta" : 0.001, # Recommended as seen in verl
539539
"auto_find_batch_size" : False, # Cannot work on GRPO
540+
# [TODO] See https://fengyao.notion.site/off-policy-rl
541+
# https://github.com/huggingface/trl/pull/3867 (August 7th)
542+
"vllm_importance_sampling_correction" : False,
540543
}
541544
for k, v in replacements.items():
542545
x = f"{k}( = [^,\n]{{1,}})?,\n"

0 commit comments

Comments
 (0)