add experimental PLY importer support (ascii and tested with simple files only)

Author: unitycoder

MainWindow.xaml.cs

@@ -448,6 +448,7 @@ private static async Task ProcessAllFiles(object workerParamsObject)
                                 }
                                 else
                                 {
+                                    Log.Write("files"+importSettings.inputFiles.Count+" i:"+i);
                                     Log.Write("Error> Failed to parse file: " + importSettings.inputFiles[i], LogEvent.Error);
                                 }
                             }
@@ -1386,7 +1387,7 @@ private void btnBrowseInput_Click(object sender, RoutedEventArgs e)
             // select single file
             var dialog = new OpenFileDialog();
             dialog.Title = "Select file to import";
-            dialog.Filter = "LAS|*.las;*.laz";
+            dialog.Filter = "Point Cloud Files|*.las;*.laz;*.ply|LAS Files|*.las;*.laz|PLY Files|*.ply|All Files|*.*";
 
             // take folder from field
             if (string.IsNullOrEmpty(txtInputFile.Text) == false)

PointCloudConverter.csproj

@@ -36,6 +36,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
+    <PackageReference Include="Ply.Net" Version="5.5.5" />
     <PackageReference Include="System.Buffers" Version="4.5.1" />
     <PackageReference Include="System.Memory" Version="4.5.5" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />

Structs/ImportFormat.cs

@@ -3,6 +3,7 @@
     public enum ImportFormat
     {
         Unknown,
-        LAS // and LAZ
+        LAS, // and LAZ
+        PLY
     }
 }

Structs/ImportSettings.cs

@@ -21,7 +21,7 @@ public class ImportSettings
         [JsonConverter(typeof(JsonStringEnumConverter))]
         public Logger.LogEvent @event { get; set; }
 
-        public IReader reader = new LAZ(null); // single threaded reader
+        public IReader reader; // single threaded reader
         //public Dictionary<int?, IReader> Readers { get; set; } = new Dictionary<int?, IReader>();
         public ConcurrentDictionary<int?, IReader> Readers { get; set; } = new ConcurrentDictionary<int?, IReader>();
         public IWriter writer = new UCPC();
@@ -48,9 +48,26 @@ public void InitWriterPool(int maxThreads, ExportFormat export)
         // Method to get or create a reader for a specific task ID
         public IReader GetOrCreateReader(int? taskId)
         {
+            //Log.Write(">>>>> Getting or creating reader for task ID: " + taskId+" format: "+importFormat);
+
             if (!Readers.ContainsKey(taskId))
             {
-                Readers[taskId] = new LAZ(taskId);
+                IReader readerInstance;
+
+                switch (importFormat)
+                {
+                    case ImportFormat.LAS:
+                        readerInstance = new LAZ(taskId);
+                        break;
+                    case ImportFormat.PLY:
+                        readerInstance = new PLY(); // no taskId needed here
+                        break;
+                    default:
+                        Log.Write($"Unsupported import format: {importFormat}", LogEvent.Error);
+                        throw new NotSupportedException($"Unsupported import format: {importFormat}");
+                }
+
+                Readers[taskId] = readerInstance;
             }
 
             //Log.Write(">>>>> Total Readers in dictionary: " + Readers.Count);

Tools/ArgParser.cs

@@ -152,18 +152,29 @@ public static ImportSettings Parse(string[] args, string rootFolder, ILogger log
 
                                 string importFormatParsed = param.ToUpper();
 
-                                // TODO check what reader interfaces are available
-                                if (string.IsNullOrEmpty(importFormatParsed) == true || (importFormatParsed != "LAS" && importFormatParsed != "LAZ"))
+                                if (string.IsNullOrEmpty(importFormatParsed) ||
+                                    (importFormatParsed != "LAS" && importFormatParsed != "LAZ" && importFormatParsed != "PLY"))
                                 {
                                     importSettings.errors.Add("Unsupported import format: " + param);
                                     importSettings.importFormat = ImportFormat.Unknown;
                                 }
                                 else
                                 {
-                                    importSettings.importFormat = ImportFormat.LAS;
-                                    importSettings.reader = new LAZ(null);
+                                    switch (importFormatParsed)
+                                    {
+                                        case "LAS":
+                                        case "LAZ":
+                                            importSettings.importFormat = ImportFormat.LAS;
+                                            importSettings.reader = new LAZ(null);
+                                            break;
+                                        case "PLY":
+                                            importSettings.importFormat = ImportFormat.PLY;
+                                            importSettings.reader = new PLY();
+                                            break;
+                                    }
                                 }
                                 break;
+
                             case "-exportformat":
                                 Log.Write("exportformat = " + param);
 
@@ -234,7 +245,7 @@ public static ImportSettings Parse(string[] args, string rootFolder, ILogger log
 
                                     // TODO get file extension from commandline param? but then need to set -format before input.. for now only LAS/LAZ
                                     // TODO parse/sort args in required order, not in given order
-                                    var filePaths = Directory.GetFiles(param).Where(file => Regex.IsMatch(file, @"^.+\.(las|laz)$", RegexOptions.IgnoreCase)).ToArray();
+                                    var filePaths = Directory.GetFiles(param).Where(file => Regex.IsMatch(file, @"^.+\.(las|laz|ply)$", RegexOptions.IgnoreCase)).ToArray();
 
 
                                     for (int j = 0; j < filePaths.Length; j++)
@@ -854,9 +865,9 @@ public static ImportSettings Parse(string[] args, string rootFolder, ILogger log
                             {
                                 importSettings.errors.Add("(E) PCROOT Requires some output filename (example: output.pcroot)");
                             }
-                            if (importSettings.exportFormat == ExportFormat.External)
+                            if (importSettings.exportFormat == ExportFormat.External && importSettings.batch == false)
                             {
-                                importSettings.errors.Add("(E2) External formats require some output filename (example: basefilename)");
+                                importSettings.errors.Add("(E2) External formats require some output filename for non-batch operations (example: basefilename)");
                             }
                         }
                     }
@@ -938,6 +949,12 @@ public static ImportSettings Parse(string[] args, string rootFolder, ILogger log
                 Log.Write("No import format defined, using Default: " + importSettings.importFormat.ToString());
             }
 
+            if (importSettings.importFormat == ImportFormat.PLY)
+            {
+                if (importSettings.importIntensity || importSettings.importClassification) Log.Write("PLY doesnt support intensity or classification importing.");
+                if (importSettings.packColors) Log.Write("PLY doesnt support color packing.");
+            }
+
             if (importSettings.exportFormat == ExportFormat.PCROOT && importSettings.useGrid == false)
             {
                 //importSettings.errors.Add("V3 pcroot export format requires -usegrid=true to use grid");