All container properties must be optional (elastic#1140)

Author: delvedor

compiler/model/build-model.ts

@@ -416,6 +416,13 @@ function compileClassOrInterfaceDeclaration (declaration: ClassDeclaration | Int
         'Class and interfaces can only have property declarations or signatures'
       )
       const property = modelProperty(member)
+      if (type.variants?.kind === 'container' && property.containerProperty == null) {
+        assert(
+          member,
+          !property.required,
+          'All @variants container properties must be optional'
+        )
+      }
       type.properties.push(property)
     }
 

output/schema/schema.json

@@ -82,7 +82,7 @@ export class PivotGroupByContainer {
  */
 export class RetentionPolicyContainer {
   /** Specifies that the transform uses a time field to set the retention policy. */
-  time: RetentionPolicy
+  time?: RetentionPolicy
 }
 
 export class RetentionPolicy {
@@ -154,7 +154,7 @@ export class Sync {}
  */
 export class SyncContainer {
   /** Specifies that the transform uses a time field to synchronize the source and destination indices. */
-  time: TimeSync
+  time?: TimeSync
 }
 
 export class TimeSync {

output/schema/validation-errors.json

@@ -24,7 +24,7 @@ import { ScheduleContainer, ScheduleTriggerEvent } from './Schedule'
  * @variants container
  */
 export class TriggerContainer {
-  schedule: ScheduleContainer
+  schedule?: ScheduleContainer
 }
 
 export class TriggerEvent {}
@@ -33,7 +33,7 @@ export class TriggerEvent {}
  * @variants container
  */
 export class TriggerEventContainer {
-  schedule: ScheduleTriggerEvent
+  schedule?: ScheduleTriggerEvent
 }
 
 export class TriggerEventResult {